Error page #403
Merged
Error page #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aprillion
approved these changes
Feb 15, 2024
app/root.tsx
Outdated
| </CachedObjectsProvider> | ||
| <BasePage embed={embed} savedTheme={savedTheme} minLogo={minLogo}> | ||
| <Outlet context={context} /> | ||
| {/* <ScrollRestoration /> wasn't doing anything useful */} |
There was a problem hiding this comment.
I wonder if we should try it again now that we use a new version of Remix and/or no longer support multiple expanded answers per page - might be nice to restore scroll position if you click on related question at the bottom of a page and then decide to go back (unless we open everything in new tabs anyway 🤣)
app/routes/questions.$questionId.tsx
Outdated
| data, | ||
| tags: [] as Tag[], | ||
| } | ||
| const msg = `No question found with ID ${questionId}. Please go to the Discord in the lower right (or click <a href="https://discord.com/invite/Bt8PaRTDQC">here</a>) and report where you found this link.` |
There was a problem hiding this comment.
old text that needs deleting/rewriting: Discord in the lower right
There was a problem hiding this comment.
I already deleted this once... :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.