-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stampy redesign 362 #404
Closed
Closed
Stampy redesign 362 #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esign # Conflicts: # package-lock.json # package.json
* use real page ids on landing page
changes the route for tag pages from tags/{tag name} to tags/{tag id}/{tag name}. Only tag id is needed to navigate to the page.
stampy.ts tests were failing (e.g. https://github.com/StampyAI/stampy-ui/actions/runs/7854687158/job/21435971107) with the following error: ``` app/server-utils/stampy.ts:196:45 - error TS2576: Property 'json' does not exist on type 'Response'. Did you mean to access the static member 'Response.json' instead? 196 json = await (await fetch(url, params)).json() ``` Removed @nodes/types as I think it was due to the types conflict described cloudflare/workerd#1298.
redirect ?state urls (#382 part 1)
feat(Input): add placeholder prop and set for Menu
Connect more
Connect more
buddy-web3
requested review from
melissasamworth,
Aprillion,
mruwnik and
jrhender
February 15, 2024 04:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@melissasamworth please note that Advanced Content follows the Acceptance Criteria, images must be added by copyright people in Coda