glossary css #407
Merged
glossary css #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aprillion
reviewed
Feb 15, 2024
app/components/Article/Contents.tsx
Outdated
| : '') + | ||
| ' </div>' + | ||
| (entry.image ? `<img src="${entry.image}" alt="${entry.term}"/>` : '') + | ||
| '</div>' |
There was a problem hiding this comment.
(minor) ah, have you considered 1 multiline string template, please? or maybe https://react.dev/reference/react-dom/server/renderToString if we need so much logic here 😅
| @@ -77,6 +76,15 @@ article .link-popup::after { | |||
| right: 100%; | |||
| } | |||
|
|
|||
| article .link-popup .glossary-popup > .contents { | |||
| padding: var(--spacing-24) var(--spacing-40) var(--spacing-24); | |||
There was a problem hiding this comment.
2 or 4 values would make more sense here IMHO, but if the bottom is same as top, repeating it looks suspicious
app/components/Article/Contents.tsx
Outdated
| ? `<a href="/${entry.pageid}" class="button secondary">View full definition</a>` | ||
| : '') + | ||
| ' </div>' + | ||
| (entry.image ? `<img src="${entry.image}" alt="${entry.term}"/>` : '') + |
There was a problem hiding this comment.
alt="" for decorative images, please!! we shouldn't make users of screen reader listen to the same header twice 😅
Aprillion
reviewed
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generally works, but might need a bit of css tweaking:
The main thing is what to do about the image size. This version just assumes it's up to the editors to get a version that looks good