fix(_index): remove large-bold class from Advanced content <h> tag #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to issue #420 , tags should only have colour and padding classes
|
@jrhender great catch thanks! So it was that H tags should never have a class. But this should actually be a p tag! Can you, convert this tag to a p and add the class |
melissasamworth
requested changes
Feb 27, 2024
app/routes/_index.tsx
Outdated
| @@ -45,7 +45,7 @@ export default function App() { | |||
| <WidgetStampy /> | |||
|
|
|||
| <div className="padding-bottom-80" /> | |||
| <h3 className="grey large-bold padding-bottom-32">Advanced content</h3> | |||
| <h3 className="grey padding-bottom-32">Advanced content</h3> | |||
There was a problem hiding this comment.
Heh no so, we want it to be a p tag, I'm not using h3s.
<p className="grey large-bold padding-bottom-32">Advanced content</p>
There was a problem hiding this comment.
@melissasamworth Thanks for the note. I changed the tag to a p.
Should it still have the padding-bottom-32 class? How can one get the desired padding from the figma?
This matches the figma
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to issue #420 , tags should only have colour and padding classes