Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

article mobile bits #451

Merged
merged 1 commit into from
Feb 27, 2024
Merged

article mobile bits #451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions app/components/Article/article.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,3 +130,12 @@ article .footer-comtainer > * {
h1.teal {
color: var(--colors-teal-500);
}
@media only screen and (max-width: 640px) {
article .footer-comtainer {
flex-direction: row;
flex-wrap: wrap;
}
article .footer-comtainer > div:nth-child(-n + 2) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a good practice to use div:nth-child as used? Perhaps an additional class would be clearer when reading the code and less likely to break unexpectedly? I don't have a strong feeling here, just thought I would ask.

Suggested change
article .footer-comtainer > div:nth-child(-n + 2) {
article .footer-comtainer .footer-section {

My CSS knowledge is limited, so my apologies if the rationale for the current approach is obvious 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both options are fine by me. @mruwnik do you prefer nth-child or a new class?

flex: 1 1;
}
}
Comment on lines +133 to +141
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small typos

Suggested change
@media only screen and (max-width: 640px) {
article .footer-comtainer {
flex-direction: row;
flex-wrap: wrap;
}
article .footer-comtainer > div:nth-child(-n + 2) {
flex: 1 1;
}
}
@media only screen and (max-width: 640px) {
article .footer-container {
flex-direction: row;
flex-wrap: wrap;
}
article .footer-container > div:nth-child(-n + 2) {
flex: 1 1;
}
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrhender I noticed the typo as well.. but it's everywhere, not just in my additions.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see. Better to keep as is then and fix in another PR I suppose.

Loading