clean up fcol-x lefovers from merge #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melissasamworth
approved these changes
May 26, 2024
| @@ -43,7 +43,7 @@ | |||
| --spacing-104: clamp(56px, 10.6vw, 104px); | |||
| --spacing-128: clamp(56px, 13.8vw, 128px); | |||
| --spacing-192: clamp(80px, 17vw, 192px); | |||
| --spacing-288: clamp(128px, 25.6vw, 288px); | |||
| --spacing-288: clamp(128px, 20vw, 288px); | |||
There was a problem hiding this comment.
I'm still uncertain about making the spacing variables vw. I use a system based on 8 to make it clean. But let's try it and see.
I definitely think we should make the columns vw with clamp, which I believe is the case now!
| @@ -498,7 +464,7 @@ svg { | |||
|
|
|||
| /* defines the standard left and right margins */ | |||
| .page-body { | |||
| padding: 0px 13.333vw; | |||
| padding: 0px var(--spacing-128); | |||
There was a problem hiding this comment.
This makes me uncomfortable but I'll merge it anyway
There was a problem hiding this comment.
vw padding on clamped width means narrower content on larger screens... so the padding also needs to be clamped (though the "correct" value might need to be changed after design review on various screen sizes I guess .. I just picked a closest option to the 13vw)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://stampy-ui2.aprillion.workers.dev/