Ticket-#597 - Reference Hover #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mruwnik
reviewed
Jun 7, 2024
| @@ -78,7 +78,10 @@ const QuestionInput = ({ | |||
| } | |||
|
|
|||
| return ( | |||
| <div className={'widget-ask ' + (fixed ? 'fixed col-10' : 'col-9')} ref={clickDetectorRef}> | |||
| <div | |||
| className={'widget-ask ' + (fixed ? 'fixed col-10 z-index-4' : 'col-9')} | |||
There was a problem hiding this comment.
would z-index-1 suffice? i.e. use the smallest possible value
melissasamworth
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Looks amazing!
- I think your design decision makes sense.
- Bonus in the future is that it goes above or below based on user's scroll position
- Now for the height, I was just envisioning that we didn't have a static height, and the height was just as long as it needed to be. I think I would prefer that but I'm cool to use this and then test it as users and see how we feel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok so I think I've done it, except its a little bit janky. i.e. in order to get the height consistent and correct, instead of editing the dangerouslyPastedHTML I've just set the overflow: hidden, and set the height of the contents div to be one which generally doesn't seem to clip words.
also, @melissasamworth I made a design decision to put the reference popup below the number (instead of above, which is on the figma), because I feel like it generally clips off less often because I notice I am more likely to be reading stuff at the top of the screen. I also like that the curser is closer to the title and link when its below. Anywho, I can change it if you disagree.
bla.mov