properly display popup content #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarSou9
reviewed
Jun 8, 2024
| '6306', // What is an intelligence explosion? debugger eval code:1:26 | ||
| '5943', // How might AGI kill people? debugger eval code:1:26 | ||
| '7748', // What is a "warning shot"? | ||
| ] |
|
Code looks fire, and seems to be working. But just to make sure @melissasamworth, you still don't want the Also, Nemo, I got this response to a question, I'm guessing there are unwritten questions where there shouldn't be in coda. |
|
Oh wait, there is also a bug, clicking on the settings causes the questions to reload. It actually might be nice to also have a refresh questions button come to think of it Screen.Recording.2024-06-08.at.10.20.09.AM.mov |
|
good catch with the bug - @melissasamworth what do you think about it? |
|
@mruwnik Let me know when you've fixed the bug and resolved conflicts so I can merge. Also my humble opinion is to keep the big loading box but up to you |
|
done |
zarSou9
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.