miscellaneous mobile fixes #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mruwnik
approved these changes
Jun 9, 2024
app/components/Feedback/Form.tsx
Outdated
| @@ -27,6 +28,9 @@ const FeedbackForm = ({onSubmit, onClose, options, className}: FeedbackFormProps | |||
|
|
|||
| return ( | |||
| <div ref={clickCheckerRef} className={'feedback-form bordered ' + (className ?? '')}> | |||
| <button onClick={onClose} className="mobile-only escape-feedback"> | |||
| <XLarge></XLarge> | |||
There was a problem hiding this comment.
<XLarge /> is how it's done when the tag doesn't have any contents
|
|
||
| @media (max-width: 780px) { | ||
| .feedback-form { | ||
| left: -20px; |
There was a problem hiding this comment.
this looks suspicious - @melissasamworth ?
There was a problem hiding this comment.
haha yes, I didn't try very hard to properly align the feedback form on mobile, because I wanted to wait until the column sizing is fixed on mobile. I could have a crack at fixing the mobile column margin but I feel like @melissasamworth had something specific in mind?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed mobile feedback, left aligned human-written-response, z-index fix