Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editor page #745

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Add editor page #745

merged 3 commits into from
Jul 11, 2024

Conversation

mruwnik
Copy link
Collaborator

@mruwnik mruwnik commented Jul 9, 2024

Adds https://aisafety.info/editors/ endpoint to help with downloading all questions

image

@@ -288,6 +289,7 @@ const convertToQuestion = ({name, values, updatedAt} = {} as AnswersRow): Questi
title: name,
pageid: extractText(values['UI ID']),
text: renderText(extractText(values['UI ID']), values['Rich Text']),
markdown: extractText(values['Rich Text']),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feels icky, adding it just for this one, hidden, place. The alternative was creating a new endpoint/function which is also icky :/

Aprillion
Aprillion previously approved these changes Jul 10, 2024
app/routes/editors.tsx Outdated Show resolved Hide resolved
@Aprillion Aprillion self-requested a review July 11, 2024 11:46
Copy link
Collaborator

@Aprillion Aprillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh god, GH mobile app interface is an abomination for doing code review... I guess the last commit is a sneaky unrelated bugfix,, but the halfway auth looks good enough (I think), thanks!

@mruwnik mruwnik merged commit f3a5bff into master Jul 11, 2024
1 check passed
@mruwnik mruwnik deleted the sundry-fixes branch July 11, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants