QA and various fixes

[bryceerobertson]

This stuff from #817:

Some stuff too complicated for me remains, e.g. making the small cards at the bottom display in a 2x2 grid when there are four of them (instead of three). I'll collect them all up and make issues.

[bryceerobertson]

@mruwnik I'm afraid the lint ghosts continue to haunt me. You're going to need to teach me how to fix it myself, lest I bother you every time to fix it

[LeMurphant]

@bryceerobertson here are the steps for debugging

• Run the following command to see if the lint will fail: npx tsc && npm run prettier && npm run eslint
• In this case, there were a few things that the lint did not like. I fixed it by running this: npx prettier --write app/{components,routes}
• This automatically fixed the lint issues. I checked the git diff to make sure the changes made sense, they did
• Ran the lint command again (the first one), gave me a few more errors. I had to diagnose them manually, but they made sense

stampy-ui/app/routes/how-can-i-help.career.tsx
  235:29  error  Irregular whitespace not allowed  no-irregular-whitespace
  235:70  error  Irregular whitespace not allowed  no-irregular-whitespace
  237:69  error  Irregular whitespace not allowed  no-irregular-whitespace
  238:45  error  Irregular whitespace not allowed  no-irregular-whitespace

stampy-ui/app/routes/how-can-i-help.volunteer.tsx
  8:8  error  'LonsImg' is defined but never used  @typescript-eslint/no-unused-vars
  8:8  error  'LonsImg' is defined but never used  unused-imports/no-unused-imports

The numbers at the start are the line number and character number. I fixed all the errors, and can push the fix to resolve the issues, but I can also let you diagnose them for yourself if you want

[mruwnik]

npm run lint:fix should also solve as much as it can, giving you the places to fix

[bryceerobertson]

Managed it! Thank you 🙏🏼

[melissasamworth]

This is amazing 🙏, I usually don't like people touching my stuff but you actually made it better. Thank you!

[melissasamworth]

I had liked this, but can't explain why. So you get your way.

[melissasamworth]

Okay, I like this actually.

[melissasamworth]

I've made the grid (widths) static, so I think this line is just obsolete. But that's fine

[melissasamworth]

Ah, I see what you were going for. This was my mistake. I don't want to add another extra-large class, but rather make all the large classes consistent. I think I will come in and fix this soon so I don't get confused when this system doesn't match my Figma later. For now it works, sorry for the confusion.

[melissasamworth]

I don't like this copy just because what we're trying to illustrate here something about how communities are grouped, not whether attending protests is important. If we really don't like including the word protests, I would just choose another activity that is common to illustrate our point. This is the only piece of feedback so far I am bullish on.

[bryceerobertson]

Agreed