Merge pull request #320 from StampyAI/microfix-tag-parsing

removed error on non-matching question status
StampyAI · Aug 18, 2023 · ba83761 · ba83761
2 parents 997d3df + 3d57364
commit ba83761
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/api/coda.py b/api/coda.py
@@ -522,18 +522,15 @@ def get_all_statuses(self) -> list[str]:
             r["Status"].value for r in status_table.rows() if r["Status"].value
         }
         # load status values defined in code
-        code_status_vals = set(get_args(QuestionStatus))
+        encoded_status_vals = set(get_args(QuestionStatus))
         # if mismatch, log and raise errory
-        if coda_status_vals != code_status_vals:
-            msg = "Status values defined in api/utilities/coda_utils.py don't match the values in coda"
-            self.log.error(
+        if coda_status_vals != encoded_status_vals:
+            self.log.warning(
                 self.class_name,
                 msg="Status values defined in api/utilities/coda_utils.py don't match the values in coda",
-                code_status_vals=code_status_vals,
+                code_status_vals=encoded_status_vals,
                 coda_status_vals=coda_status_vals,
             )
-            msg += f"; {code_status_vals=}; {coda_status_vals=}"
-            raise AssertionError(msg)
         return sorted(coda_status_vals)
 
     @staticmethod

diff --git a/api/utilities/coda_utils.py b/api/utilities/coda_utils.py
@@ -64,6 +64,7 @@ class QuestionRow(TypedDict):
 QuestionStatus = Literal[
     "Bulletpoint sketch",
     "Duplicate",
+    "Dormant",
     "In progress",
     "In review",
     "Live on site",