-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed stamp karma to proper(ish) PageRank. #213
base: master
Are you sure you want to change the base?
Conversation
Changed log_error and log_exception to not be async, made log_error_async and log_exception_async instead. Old names now get the event loop for you and await the async versions for you. Changed some logging messages. Added a recalculatestamps command which can be used for debugging, otherwise it's pretty much useless. Added a get_total_drains utility function to see how many drains there are in the PageRank calculation.
886779f
to
a99b72b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(minor) would be nicer to split the unrelated changes into 2 commits instead of just 1 commit for both log_error changes and karma changes..
Co-authored-by: Peter Hozák <[email protected]>
Yeah, I thought about it, but I did the karma first then realized I made the log error system in a stupid way when I went to implement it. |
Co-authored-by: Peter Hozák <[email protected]>
I think... GitHub broke my PR... |
Without yet putting on my math hat or opening up VSCode - I imagine a professional code reviewer might say:
|
Changed log_error and log_exception to not be async, made log_error_async and log_exception_async instead. Old names now get the event loop for you and await the async versions for you. Changed some logging messages.
Added a recalculatestamps command which can be used for debugging, otherwise it's pretty much useless. Added a get_total_drains utility function to see how many drains there are in the PageRank calculation.
Waiting for Rob's review before merge.
(ish) comes from the fact that we're not supposed to do proper PageRank.