Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix question detection #317

Merged
merged 4 commits into from
Jul 5, 2023
Merged

Conversation

MatthewBaggins
Copy link
Collaborator

Fixes #297 , i.e., this bug

User: I think mine’s done, i’ve gone on to checking the stampychat code for embedding the huggingface dataset. The PR
requires a review, and also says ‘this branch has conflicts that must be resolved’, but it said that earlier and I merged it with main, and I’m guessing I don’t have to do that continually we can just do it before or as the PR gets accepted?
Edit: btw despite saying ‘requiring a review’ I think it’s pretty much been reviewed already so maybe I meant it required an approval but perhaps there’s some bug I haven’t figured out who knows)

Stampy: You're not a reviewer, @user -_-

and also this bug

Screenshot from 2023-07-05 17-05-22

( 🤞 )

@MatthewBaggins MatthewBaggins merged commit f46b14b into master Jul 5, 2023
@ProducerMatt ProducerMatt deleted the hotfix-question-detection branch August 13, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

question_setter module firing at unwanted times
2 participants