Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes some changes to
inferencedata1
. The main ones are:_symbol
, use the suffix_var
for keyword args. This is consistent with thefrom_cmdstan
,from_pystan
, andfrom_cmdstanpy
methods in Python ArviZ and would be more familiar for a Python Stan user coming to Julia._var
keyword args can now takeSymbol
, or an iterator ofSymbol
s.predictions_var
keyword argsplit_nt
andsplit_nt_all
convenience methods and refactor to use them for splitting the samples named tuple into the various group named tuplesHere's an example output, using the notebook at https://github.com/StanJulia/Stan.jl/blob/master/Examples_Notebooks/InferenceObjects.jl
Note that in the next breaking release of InferenceObjects, the dimension orders of arrays will change (arviz-devs/InferenceObjects.jl#40), and the default indices for all dimensions will be the
axes
of the underlying arrays (arviz-devs/InferenceObjects.jl#39; so after splitting samples from warmup, no reindexing will be needed)