Fix issue with extra arguments being ignored #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @zeyus, merged your pull request in v7.10.0. Should be published in the next hour or so. |
|
@goedman Amazing, thanks :) |
|
@zeyus You're welcome. If you have an example of using your fix, I wouldn't mind adding it as a test. |
No probs, I have created a new PR with a test and due to that process discovered a couple of minor issues along the way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the configurable options that should be passed to
cmdstanwere getting ignored, this just passes along thekwargsso that the final command executed includes the correct settings.