Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to pwl_cos #4

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Updates to pwl_cos #4

wants to merge 4 commits into from

Conversation

sgherbst
Copy link
Contributor

This small PR just affects pwl_cos. I made a few updates for compatibility with DragonPHY, and also added more comments to explain how the model works. Updates:

  1. The mLingua header is now included at the top. Since the header has an include guard, I don't think there's a drawback to including it everywhere that it is used. (This makes it easier to user the library)
  2. The cos function is no longer imported DPI-C but is instead included from the mLingua header (a previous update to the header switched the cosine implementation to the system task $cos).

@sgherbst sgherbst requested a review from standanley April 29, 2020 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@standanley standanley Awaiting requested review from standanley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgherbst @standanley