[Enhancement] If hostPath is set, the storage class will be considered as hostPath #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yandongxiao
force-pushed
the
enhancement/hostpath-volume
branch
2 times, most recently
from
10dd527 to
02c2762
Compare
…d as hostPath Signed-off-by: yandongxiao <[email protected]>
yandongxiao
force-pushed
the
enhancement/hostpath-volume
branch
from
02c2762 to
87ad5ae
Compare
kevincai
reviewed
Jun 24, 2024
pkg/k8sutils/templates/pod/mount.go
Outdated
| // SpecialStorageClassName returns the special storage class name of the storage volume, else return "". | ||
| // Now we support HostPath and EmptyDir as special storage class. | ||
| func SpecialStorageClassName(sv v1.StorageVolume) string { | ||
| if sv.HostPath != nil { |
There was a problem hiding this comment.
what if the the sv.HostPath is provided and the sv.StorageClassName is provided as well and they mismatch?
There was a problem hiding this comment.
Good catch. I think the storage class name will have a high priority.
…me is provided as well, name will have a high priority Signed-off-by: yandongxiao <[email protected]>
kevincai
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Fixes: #485
Checklist
For operator, please complete the following checklist:
make generateto generate the code.golangci-lint runto check the code style.make testto run UT.make manifeststo update the yaml files of CRD.