[Enhancement]parquet reader supports low cardinality optimization #55167
+700
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zombee0
force-pushed
the
parquet_global_dict
branch
from
8ff2748 to
a834e45
Compare
Signed-off-by: zombee0 <[email protected]>
zombee0
force-pushed
the
parquet_global_dict
branch
from
a834e45 to
4227e55
Compare
trueeyu
reviewed
Jan 17, 2025
|
|
||
| if (_tmp_column == nullptr) { | ||
| _tmp_column = ColumnHelper::create_column(TypeDescriptor::from_logical_type(TYPE_VARCHAR), true); | ||
| } |
There was a problem hiding this comment.
Use TYPE_VARCHAR_DESC instead of TypeDescriptor::from_logical_type(TYPE_VARCHAR) ?
trueeyu
reviewed
Jan 17, 2025
| nullable_dst->set_has_null(nullable_codes->has_null()); | ||
| } | ||
|
|
||
| src->reset_column(); |
There was a problem hiding this comment.
src is used as temp column to store intermediate result, fill_dst_column means we have got a chunk of data, next time we call get_next, we will append data to it.
trueeyu
reviewed
Jan 17, 2025
| array_column_dst = down_cast<ArrayColumn*>(nullable_column_dst->mutable_data_column()); | ||
| NullColumn* null_column_dst = nullable_column_dst->mutable_null_column(); | ||
| null_column_dst->swap_column(*null_column_src); | ||
| nullable_column_src->update_has_null(); |
There was a problem hiding this comment.
Why not directly swap the flag of src_nullable_column and dst_nullable_column?
There was a problem hiding this comment.
for data column, we fill it with reader
trueeyu
reviewed
Jan 17, 2025
| array_column_src = down_cast<ArrayColumn*>(src.get()); | ||
| array_column_dst = down_cast<ArrayColumn*>(dst.get()); | ||
| } | ||
| array_column_dst->offsets_column()->swap_column(*(array_column_src->offsets_column())); |
There was a problem hiding this comment.
Why not use ArrayColumn::swap_column?
There was a problem hiding this comment.
we only swap offset and nullcolumn, for element_column, we fill it with element_reader
Signed-off-by: zombee0 <[email protected]>
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 175 / 195 (89.74%) file detail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: