-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Skip load primary index for empty rowset #55628
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sevev <[email protected]>
@mergify rebase |
✅ Branch has been successfully rebased |
bc534b9
to
8badc54
Compare
Signed-off-by: sevev <[email protected]>
8badc54
to
074de91
Compare
Signed-off-by: sevev <[email protected]>
luohaha
reviewed
Feb 10, 2025
Signed-off-by: sevev <[email protected]>
luohaha
approved these changes
Feb 10, 2025
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 12 / 14 (85.71%) file detail
|
wyb
approved these changes
Feb 11, 2025
@Mergifyio backport branch-3.4 |
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
Signed-off-by: sevev <[email protected]> (cherry picked from commit 2439c47)
mergify bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
Signed-off-by: sevev <[email protected]> (cherry picked from commit 2439c47)
This was referenced Feb 11, 2025
wanpengfei-git
pushed a commit
that referenced
this pull request
Feb 11, 2025
…) (#55807) Co-authored-by: zhangqiang <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Feb 11, 2025
…) (#55806) Co-authored-by: zhangqiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
During the publish process, the primary index is loaded, which consumes additional memory. However, for empty rowsets, loading the primary index is unnecessary. Skipping the loading of the primary index can save memory and improve the efficiency of the publish operation.
What I'm doing:
Skip load primary index for empty rowset.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: