Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Skip load primary index for empty rowset #55628

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

sevev
Copy link
Contributor

@sevev sevev commented Feb 6, 2025

Why I'm doing:

During the publish process, the primary index is loaded, which consumes additional memory. However, for empty rowsets, loading the primary index is unnecessary. Skipping the loading of the primary index can save memory and improve the efficiency of the publish operation.

What I'm doing:

Skip load primary index for empty rowset.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@sevev sevev requested a review from a team as a code owner February 6, 2025 13:07
@mergify mergify bot assigned sevev Feb 6, 2025
@sevev
Copy link
Contributor Author

sevev commented Feb 7, 2025

@mergify rebase

Copy link
Contributor

mergify bot commented Feb 7, 2025

rebase

✅ Branch has been successfully rebased

Signed-off-by: sevev <[email protected]>
Signed-off-by: sevev <[email protected]>
Signed-off-by: sevev <[email protected]>
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 12 / 14 (85.71%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/lake/update_manager.cpp 4 6 66.67% [1133, 1134]
🔵 be/src/storage/lake/txn_log_applier.cpp 8 8 100.00% []

@wyb wyb merged commit 2439c47 into StarRocks:main Feb 11, 2025
48 checks passed
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Feb 11, 2025
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Feb 11, 2025
Copy link
Contributor

mergify bot commented Feb 11, 2025

backport branch-3.4

✅ Backports have been created

Copy link
Contributor

mergify bot commented Feb 11, 2025

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 11, 2025
mergify bot pushed a commit that referenced this pull request Feb 11, 2025
wanpengfei-git pushed a commit that referenced this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants