Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we at Optibus have an issue with patches that are created when two arrays are compared - the second is a filter result of the first.
instead of having a simple remove patch, we can get a few hundred (or even thousands) of replace patches.
the suggested code, using lodash's 'difference', is trying to detect those cases and use a simple 'remove' or 'add' patch.
it also reverts to old code in cases where:
a. the result is simply wrong - mostly like the difference between the arrays is a big one.
b. the differences are so great there is probably no added value.
I added 1000 tests with random arrays. so i believe the solution is solid.
regarding the tests that fail - i would consider removing them