Skip to content

#21 Removed hardcoded postgres user from initialization script #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#21 Removed hardcoded postgres user from initialization script #22

wants to merge 1 commit into from

Conversation

@azapasnik
Copy link

@azapasnik azapasnik commented Apr 23, 2019

No description provided.

@am17torres
Copy link

am17torres commented Mar 13, 2020

Can this happen?

@azapasnik
Copy link
Author

azapasnik commented Mar 13, 2020

Hi @am17torres. What do you mean?

@am17torres
Copy link

am17torres commented Apr 10, 2020

Hi @am17torres. What do you mean?

I would just love to see this PR merged :)

cinco
cinco approved these changes Jan 29, 2021
View reviewed changes
Copy link

@cinco cinco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, although it requires the use of the POSTGRES_USER variable but I believe it is suitable for general use.

cinco
cinco approved these changes Jan 29, 2021
View reviewed changes
Copy link

@cinco cinco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, although it requires the use of the POSTGRES_USER variable but I believe it is suitable for general use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cinco cinco cinco approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@azapasnik @am17torres @cinco