-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump sentry-ruby from 5.22.1 to 5.22.2 #715
Closed
Closed
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [sentry-ruby](https://github.com/getsentry/sentry-ruby) from 5.22.1 to 5.22.2. - [Release notes](https://github.com/getsentry/sentry-ruby/releases) - [Changelog](https://github.com/getsentry/sentry-ruby/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-ruby@5.22.1...5.22.2) --- updated-dependencies: - dependency-name: sentry-ruby dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
gem compare concurrent-ruby 1.3.4 1.3.5 Compared versions: ["1.3.4", "1.3.5"]
DIFFERENT date:
1.3.4: 2024-08-10 00:00:00 UTC
1.3.5: 2025-01-15 00:00:00 UTC
DIFFERENT version:
1.3.4: 1.3.4
1.3.5: 1.3.5
DIFFERENT files:
1.3.4->1.3.5:
* Changed:
CHANGELOG.md +12/-2
README.md +1/-1
Rakefile +2/-0
ext/concurrent-ruby/com/concurrent_ruby/ext/jsr166e/ConcurrentHashMapV8.java +1/-1
ext/concurrent-ruby/com/concurrent_ruby/ext/jsr166e/nounsafe/ConcurrentHashMapV8.java +1/-1
lib/concurrent-ruby/concurrent/agent.rb +2/-2
lib/concurrent-ruby/concurrent/async.rb +1/-1
lib/concurrent-ruby/concurrent/atom.rb +1/-1
lib/concurrent-ruby/concurrent/concern/logging.rb +17/-12
lib/concurrent-ruby/concurrent/delay.rb +1/-1
lib/concurrent-ruby/concurrent/executor/fixed_thread_pool.rb +1/-1
lib/concurrent-ruby/concurrent/executor/single_thread_executor.rb +1/-1
lib/concurrent-ruby/concurrent/map.rb +1/-1
lib/concurrent-ruby/concurrent/promise.rb +1/-1
lib/concurrent-ruby/concurrent/scheduled_task.rb +1/-1
lib/concurrent-ruby/concurrent/synchronization/abstract_struct.rb +1/-1
lib/concurrent-ruby/concurrent/synchronization/object.rb +1/-1
lib/concurrent-ruby/concurrent/thread_safe/util/adder.rb +1/-1
lib/concurrent-ruby/concurrent/thread_safe/util/xor_shift_random.rb +1/-1
lib/concurrent-ruby/concurrent/version.rb +1/-1
DIFFERENT extra_rdoc_files:
1.3.4->1.3.5:
* Changed:
README.md +1/-1
CHANGELOG.md +12/-2 |
gem compare --diff concurrent-ruby 1.3.4 1.3.5 Compared versions: ["1.3.4", "1.3.5"]
DIFFERENT files:
1.3.4->1.3.5:
* Changed:
CHANGELOG.md
--- /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.4/CHANGELOG.md 2025-01-27 03:38:07.329960074 +0000
+++ /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.5/CHANGELOG.md 2025-01-27 03:38:07.353960313 +0000
@@ -2,0 +3,10 @@
+## Release v1.3.5, edge v0.7.2 (15 January 2025)
+
+concurrent-ruby:
+
+* (#1062) Remove dependency on logger.
+
+concurrent-ruby-edge:
+
+* (#1062) Remove dependency on logger.
+
@@ -299 +309 @@
- - No longers supports executor injection
+ - No longer supports executor injection
@@ -474 +484 @@
-* Removed confusing warning when not using native extenstions
+* Removed confusing warning when not using native extensions
README.md
--- /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.4/README.md 2025-01-27 03:38:07.330960084 +0000
+++ /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.5/README.md 2025-01-27 03:38:07.353960313 +0000
@@ -287 +287 @@
-If the library does not behave as expected, `Concurrent.use_stdlib_logger(Logger::DEBUG)` could
+If the library does not behave as expected, `Concurrent.use_simple_logger(:DEBUG)` could
Rakefile
--- /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.4/Rakefile 2025-01-27 03:38:07.330960084 +0000
+++ /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.5/Rakefile 2025-01-27 03:38:07.354960323 +0000
@@ -14,0 +15,2 @@
+ ext.source_version = '8'
+ ext.target_version = '8'
ext/concurrent-ruby/com/concurrent_ruby/ext/jsr166e/ConcurrentHashMapV8.java
--- /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.4/ext/concurrent-ruby/com/concurrent_ruby/ext/jsr166e/ConcurrentHashMapV8.java 2025-01-27 03:38:07.332960104 +0000
+++ /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.5/ext/concurrent-ruby/com/concurrent_ruby/ext/jsr166e/ConcurrentHashMapV8.java 2025-01-27 03:38:07.356960343 +0000
@@ -484 +484 @@
- * leave untouched but unused constructor arguments refering to
+ * leave untouched but unused constructor arguments referring to
ext/concurrent-ruby/com/concurrent_ruby/ext/jsr166e/nounsafe/ConcurrentHashMapV8.java
--- /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.4/ext/concurrent-ruby/com/concurrent_ruby/ext/jsr166e/nounsafe/ConcurrentHashMapV8.java 2025-01-27 03:38:07.333960114 +0000
+++ /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.5/ext/concurrent-ruby/com/concurrent_ruby/ext/jsr166e/nounsafe/ConcurrentHashMapV8.java 2025-01-27 03:38:07.357960353 +0000
@@ -487 +487 @@
- * leave untouched but unused constructor arguments refering to
+ * leave untouched but unused constructor arguments referring to
lib/concurrent-ruby/concurrent/agent.rb
--- /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/agent.rb 2025-01-27 03:38:07.334960124 +0000
+++ /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.5/lib/concurrent-ruby/concurrent/agent.rb 2025-01-27 03:38:07.358960363 +0000
@@ -374 +374 @@
- # @raise [Concurrent::TimeoutError] when timout is reached
+ # @raise [Concurrent::TimeoutError] when timeout is reached
@@ -480 +480 @@
- # @raise [Concurrent::TimeoutError] when timout is reached
+ # @raise [Concurrent::TimeoutError] when timeout is reached
lib/concurrent-ruby/concurrent/async.rb
--- /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/async.rb 2025-01-27 03:38:07.335960134 +0000
+++ /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.5/lib/concurrent-ruby/concurrent/async.rb 2025-01-27 03:38:07.359960373 +0000
@@ -221 +221 @@
- # Instanciate a new object and ensure proper initialization of the
+ # Instantiate a new object and ensure proper initialization of the
lib/concurrent-ruby/concurrent/atom.rb
--- /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/atom.rb 2025-01-27 03:38:07.335960134 +0000
+++ /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.5/lib/concurrent-ruby/concurrent/atom.rb 2025-01-27 03:38:07.359960373 +0000
@@ -116 +116 @@
- # is acceptable else return false (preferrably) or raise an exception.
+ # is acceptable else return false (preferably) or raise an exception.
lib/concurrent-ruby/concurrent/concern/logging.rb
--- /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/concern/logging.rb 2025-01-27 03:38:07.340960184 +0000
+++ /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.5/lib/concurrent-ruby/concurrent/concern/logging.rb 2025-01-27 03:38:07.364960423 +0000
@@ -1 +0,0 @@
-require 'logger'
@@ -11 +10,3 @@
- include Logger::Severity
+ # The same as Logger::Severity but we copy it here to avoid a dependency on the logger gem just for these 7 constants
+ DEBUG, INFO, WARN, ERROR, FATAL, UNKNOWN = 0, 1, 2, 3, 4, 5
+ SEV_LABEL = %w[DEBUG INFO WARN ERROR FATAL ANY].freeze
@@ -14 +15 @@
- # @param [Integer] level one of Logger::Severity constants
+ # @param [Integer] level one of Concurrent::Concern::Logging constants
@@ -26 +27 @@
- $stderr.puts "`Concurrent.configuration.logger` failed to log #{[level, progname, message, block]}\n" +
+ $stderr.puts "`Concurrent.global_logger` failed to log #{[level, progname, message, block]}\n" +
@@ -36,2 +37,4 @@
- # @return [Logger] Logger with provided level and output.
- def self.create_simple_logger(level = Logger::FATAL, output = $stderr)
+ # Create a simple logger with provided level and output.
+ def self.create_simple_logger(level = :FATAL, output = $stderr)
+ level = Concern::Logging.const_get(level) unless level.is_a?(Integer)
+
@@ -55 +58 @@
- Logger::SEV_LABEL[severity],
+ Concern::Logging::SEV_LABEL[severity],
@@ -63 +66 @@
- def self.use_simple_logger(level = Logger::FATAL, output = $stderr)
+ def self.use_simple_logger(level = :FATAL, output = $stderr)
@@ -67 +70,2 @@
- # @return [Logger] Logger with provided level and output.
+ # Create a stdlib logger with provided level and output.
+ # If you use this deprecated method you might need to add logger to your Gemfile to avoid warnings from Ruby 3.3.5+.
@@ -69 +73,2 @@
- def self.create_stdlib_logger(level = Logger::FATAL, output = $stderr)
+ def self.create_stdlib_logger(level = :FATAL, output = $stderr)
+ require 'logger'
@@ -96 +101 @@
- def self.use_stdlib_logger(level = Logger::FATAL, output = $stderr)
+ def self.use_stdlib_logger(level = :FATAL, output = $stderr)
@@ -106 +111 @@
- GLOBAL_LOGGER = AtomicReference.new(create_simple_logger(Logger::WARN))
+ GLOBAL_LOGGER = AtomicReference.new(create_simple_logger(:WARN))
lib/concurrent-ruby/concurrent/concurrent_ruby.jar
Binary files /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/concurrent_ruby.jar and /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.5/lib/concurrent-ruby/concurrent/concurrent_ruby.jar differ
lib/concurrent-ruby/concurrent/delay.rb
--- /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/delay.rb 2025-01-27 03:38:07.342960204 +0000
+++ /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.5/lib/concurrent-ruby/concurrent/delay.rb 2025-01-27 03:38:07.366960443 +0000
@@ -22 +22 @@
- # enclosed opration will be run and the calling thread will block. Other
+ # enclosed operation will be run and the calling thread will block. Other
lib/concurrent-ruby/concurrent/executor/fixed_thread_pool.rb
--- /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/executor/fixed_thread_pool.rb 2025-01-27 03:38:07.343960213 +0000
+++ /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.5/lib/concurrent-ruby/concurrent/executor/fixed_thread_pool.rb 2025-01-27 03:38:07.367960453 +0000
@@ -86 +86 @@
- # this method explicitely in case your application post jobs in bursts (a
+ # this method explicitly in case your application post jobs in bursts (a
lib/concurrent-ruby/concurrent/executor/single_thread_executor.rb
--- /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/executor/single_thread_executor.rb 2025-01-27 03:38:07.345960233 +0000
+++ /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.5/lib/concurrent-ruby/concurrent/executor/single_thread_executor.rb 2025-01-27 03:38:07.368960463 +0000
@@ -30 +30 @@
- # encapsulates all these bahaviors. The task processor is highly resilient
+ # encapsulates all these behaviors. The task processor is highly resilient
lib/concurrent-ruby/concurrent/map.rb
--- /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/map.rb 2025-01-27 03:38:07.346960243 +0000
+++ /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.5/lib/concurrent-ruby/concurrent/map.rb 2025-01-27 03:38:07.370960482 +0000
@@ -151 +151 @@
- # a key => value mapping might have already been created by a different thread (key?(key) would then return true, this elsif branch wouldn't be taken and an incorrent +nil+ value
+ # a key => value mapping might have already been created by a different thread (key?(key) would then return true, this elsif branch wouldn't be taken and an incorrect +nil+ value
lib/concurrent-ruby/concurrent/promise.rb
--- /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/promise.rb 2025-01-27 03:38:07.347960253 +0000
+++ /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.5/lib/concurrent-ruby/concurrent/promise.rb 2025-01-27 03:38:07.371960492 +0000
@@ -106 +106 @@
- # child Promise finishes intialization it may be in a different state than its
+ # child Promise finishes initialization it may be in a different state than its
lib/concurrent-ruby/concurrent/scheduled_task.rb
--- /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/scheduled_task.rb 2025-01-27 03:38:07.348960263 +0000
+++ /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.5/lib/concurrent-ruby/concurrent/scheduled_task.rb 2025-01-27 03:38:07.371960492 +0000
@@ -196 +196 @@
- # The `delay` value given at instanciation.
+ # The `delay` value given at instantiation.
lib/concurrent-ruby/concurrent/synchronization/abstract_struct.rb
--- /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/synchronization/abstract_struct.rb 2025-01-27 03:38:07.349960273 +0000
+++ /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.5/lib/concurrent-ruby/concurrent/synchronization/abstract_struct.rb 2025-01-27 03:38:07.372960502 +0000
@@ -160 +160 @@
- clazz.send :remove_method, member if clazz.instance_methods.include? member
+ clazz.send :remove_method, member if clazz.instance_methods(false).include? member
lib/concurrent-ruby/concurrent/synchronization/object.rb
--- /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/synchronization/object.rb 2025-01-27 03:38:07.349960273 +0000
+++ /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.5/lib/concurrent-ruby/concurrent/synchronization/object.rb 2025-01-27 03:38:07.373960512 +0000
@@ -61 +61 @@
- # The instance variable should be accessed oly through generated methods.
+ # The instance variable should be accessed only through generated methods.
lib/concurrent-ruby/concurrent/thread_safe/util/adder.rb
--- /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/thread_safe/util/adder.rb 2025-01-27 03:38:07.350960283 +0000
+++ /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.5/lib/concurrent-ruby/concurrent/thread_safe/util/adder.rb 2025-01-27 03:38:07.374960522 +0000
@@ -12 +12 @@
- # A Ruby port of the Doug Lea's jsr166e.LondAdder class version 1.8
+ # A Ruby port of the Doug Lea's jsr166e.LongAdder class version 1.8
lib/concurrent-ruby/concurrent/thread_safe/util/xor_shift_random.rb
--- /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/thread_safe/util/xor_shift_random.rb 2025-01-27 03:38:07.351960293 +0000
+++ /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.5/lib/concurrent-ruby/concurrent/thread_safe/util/xor_shift_random.rb 2025-01-27 03:38:07.374960522 +0000
@@ -18 +18 @@
- # if (x = XorShiftRandom.xorshift).odd? # thread-localy generate a next random number
+ # if (x = XorShiftRandom.xorshift).odd? # thread-locally generate a next random number
lib/concurrent-ruby/concurrent/version.rb
--- /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/version.rb 2025-01-27 03:38:07.352960303 +0000
+++ /tmp/d20250127-2511-85q8v5/concurrent-ruby-1.3.5/lib/concurrent-ruby/concurrent/version.rb 2025-01-27 03:38:07.376960542 +0000
@@ -2 +2 @@
- VERSION = '1.3.4'
+ VERSION = '1.3.5' |
gem compare sentry-ruby 5.22.1 5.22.2 Compared versions: ["5.22.1", "5.22.2"]
DIFFERENT date:
5.22.1: 2024-12-16 00:00:00 UTC
5.22.2: 2025-01-24 00:00:00 UTC
DIFFERENT homepage:
5.22.1: https://github.com/getsentry/sentry-ruby/tree/5.22.1/sentry-ruby
5.22.2: https://github.com/getsentry/sentry-ruby/tree/5.22.2/sentry-ruby
DIFFERENT metadata:
5.22.1: {"homepage_uri" => "https://github.com/getsentry/sentry-ruby/tree/5.22.1/sentry-ruby", "source_code_uri" => "https://github.com/getsentry/sentry-ruby/tree/5.22.1/sentry-ruby", "changelog_uri" => "https://github.com/getsentry/sentry-ruby/blob/5.22.1/CHANGELOG.md", "bug_tracker_uri" => "https://github.com/getsentry/sentry-ruby/issues", "documentation_uri" => "http://www.rubydoc.info/gems/sentry-ruby/5.22.1"}
5.22.2: {"homepage_uri" => "https://github.com/getsentry/sentry-ruby/tree/5.22.2/sentry-ruby", "source_code_uri" => "https://github.com/getsentry/sentry-ruby/tree/5.22.2/sentry-ruby", "changelog_uri" => "https://github.com/getsentry/sentry-ruby/blob/5.22.2/CHANGELOG.md", "bug_tracker_uri" => "https://github.com/getsentry/sentry-ruby/issues", "documentation_uri" => "http://www.rubydoc.info/gems/sentry-ruby/5.22.2"}
DIFFERENT rubygems_version:
5.22.1: 3.5.22
5.22.2: 3.6.2
DIFFERENT version:
5.22.1: 5.22.1
5.22.2: 5.22.2
DIFFERENT files:
5.22.1->5.22.2:
* Changed:
Gemfile +2/-0
README.md +1/-1
lib/sentry-ruby.rb +3/-0
lib/sentry/backtrace.rb +4/-3
lib/sentry/client.rb +14/-8
lib/sentry/cron/monitor_check_ins.rb +3/-3
lib/sentry/metrics/timing.rb +8/-0
lib/sentry/net/http.rb +2/-1
lib/sentry/version.rb +1/-1
DIFFERENT extra_rdoc_files:
5.22.1->5.22.2:
* Changed:
README.md +1/-1 |
gem compare --diff sentry-ruby 5.22.1 5.22.2 Compared versions: ["5.22.1", "5.22.2"]
DIFFERENT files:
5.22.1->5.22.2:
* Changed:
Gemfile
--- /tmp/d20250127-3510-vbc59j/sentry-ruby-5.22.1/Gemfile 2025-01-27 03:38:29.549179284 +0000
+++ /tmp/d20250127-3510-vbc59j/sentry-ruby-5.22.2/Gemfile 2025-01-27 03:38:29.563179422 +0000
@@ -11,0 +12,2 @@
+gem "ostruct" if RUBY_VERSION >= "3.4"
+
README.md
--- /tmp/d20250127-3510-vbc59j/sentry-ruby-5.22.1/README.md 2025-01-27 03:38:29.549179284 +0000
+++ /tmp/d20250127-3510-vbc59j/sentry-ruby-5.22.2/README.md 2025-01-27 03:38:29.563179422 +0000
@@ -36 +36 @@
-We test from Ruby 2.4 to Ruby 3.2 at the latest patchlevel/teeny version. We also support JRuby 9.0.
+We test from Ruby 2.4 to Ruby 3.4 at the latest patchlevel/teeny version. We also support JRuby 9.0.
lib/sentry-ruby.rb
--- /tmp/d20250127-3510-vbc59j/sentry-ruby-5.22.1/lib/sentry-ruby.rb 2025-01-27 03:38:29.550179294 +0000
+++ /tmp/d20250127-3510-vbc59j/sentry-ruby-5.22.2/lib/sentry-ruby.rb 2025-01-27 03:38:29.564179432 +0000
@@ -310,0 +311,3 @@
+ rescue ThreadError
+ # In some rare cases this may be called in a trap context so we need to handle it gracefully
+ @main_hub
lib/sentry/backtrace.rb
--- /tmp/d20250127-3510-vbc59j/sentry-ruby-5.22.1/lib/sentry/backtrace.rb 2025-01-27 03:38:29.550179294 +0000
+++ /tmp/d20250127-3510-vbc59j/sentry-ruby-5.22.2/lib/sentry/backtrace.rb 2025-01-27 03:38:29.564179432 +0000
@@ -15 +15 @@
- (?: :in\s('|`)([^']+)')?$
+ (?: :in\s('|`)(?:([\w:]+)\#)?([^']+)')?$
@@ -39,0 +40 @@
+
@@ -41 +42 @@
- _, file, number, _, method = ruby_match.to_a
+ _, file, number, _, module_name, method = ruby_match.to_a
@@ -43 +44 @@
- module_name = nil
+ module_name = module_name
lib/sentry/client.rb
--- /tmp/d20250127-3510-vbc59j/sentry-ruby-5.22.1/lib/sentry/client.rb 2025-01-27 03:38:29.551179304 +0000
+++ /tmp/d20250127-3510-vbc59j/sentry-ruby-5.22.2/lib/sentry/client.rb 2025-01-27 03:38:29.565179441 +0000
@@ -186,2 +186,5 @@
- if event.nil?
- log_debug("Discarded event because before_send returned nil")
+ unless event.is_a?(ErrorEvent)
+ # Avoid serializing the event object in this case because we aren't sure what it is and what it contains
+ log_debug(<<~MSG)
+ Discarded event because before_send didn't return a Sentry::ErrorEvent object but an instance of #{event.class}
+ MSG
@@ -196,6 +199 @@
- if event.nil?
- log_debug("Discarded event because before_send_transaction returned nil")
- transport.record_lost_event(:before_send, "transaction")
- transport.record_lost_event(:before_send, "span", num: spans_before + 1)
- return
- else
+ if event.is_a?(TransactionEvent)
@@ -204,0 +203,8 @@
+ else
+ # Avoid serializing the event object in this case because we aren't sure what it is and what it contains
+ log_debug(<<~MSG)
+ Discarded event because before_send_transaction didn't return a Sentry::TransactionEvent object but an instance of #{event.class}
+ MSG
+ transport.record_lost_event(:before_send, "transaction")
+ transport.record_lost_event(:before_send, "span", num: spans_before + 1)
+ return
lib/sentry/cron/monitor_check_ins.rb
--- /tmp/d20250127-3510-vbc59j/sentry-ruby-5.22.1/lib/sentry/cron/monitor_check_ins.rb 2025-01-27 03:38:29.552179314 +0000
+++ /tmp/d20250127-3510-vbc59j/sentry-ruby-5.22.2/lib/sentry/cron/monitor_check_ins.rb 2025-01-27 03:38:29.566179451 +0000
@@ -17 +17 @@
- start = Sentry.utc_now.to_i
+ start = Metrics::Timing.duration_start
@@ -22 +22 @@
- duration = Sentry.utc_now.to_i - start
+ duration = Metrics::Timing.duration_end(start)
@@ -32 +32 @@
- duration = Sentry.utc_now.to_i - start
+ duration = Metrics::Timing.duration_end(start)
lib/sentry/metrics/timing.rb
--- /tmp/d20250127-3510-vbc59j/sentry-ruby-5.22.1/lib/sentry/metrics/timing.rb 2025-01-27 03:38:29.557179363 +0000
+++ /tmp/d20250127-3510-vbc59j/sentry-ruby-5.22.2/lib/sentry/metrics/timing.rb 2025-01-27 03:38:29.571179500 +0000
@@ -39,0 +40,8 @@
+
+ def duration_start
+ Process.clock_gettime(Process::CLOCK_MONOTONIC)
+ end
+
+ def duration_end(start)
+ Process.clock_gettime(Process::CLOCK_MONOTONIC) - start
+ end
lib/sentry/net/http.rb
--- /tmp/d20250127-3510-vbc59j/sentry-ruby-5.22.1/lib/sentry/net/http.rb 2025-01-27 03:38:29.557179363 +0000
+++ /tmp/d20250127-3510-vbc59j/sentry-ruby-5.22.2/lib/sentry/net/http.rb 2025-01-27 03:38:29.571179500 +0000
@@ -15,0 +16 @@
+ URI_PARSER = URI.const_defined?("RFC2396_PARSER") ? URI::RFC2396_PARSER : URI::DEFAULT_PARSER
@@ -69 +70 @@
- uri = req.uri || URI.parse(URI::DEFAULT_PARSER.escape("#{use_ssl? ? 'https' : 'http'}://#{hostname}#{req.path}"))
+ uri = req.uri || URI.parse(URI_PARSER.escape("#{use_ssl? ? 'https' : 'http'}://#{hostname}#{req.path}"))
lib/sentry/version.rb
--- /tmp/d20250127-3510-vbc59j/sentry-ruby-5.22.1/lib/sentry/version.rb 2025-01-27 03:38:29.562179412 +0000
+++ /tmp/d20250127-3510-vbc59j/sentry-ruby-5.22.2/lib/sentry/version.rb 2025-01-27 03:38:29.576179549 +0000
@@ -4 +4 @@
- VERSION = "5.22.1"
+ VERSION = "5.22.2" |
Superseded by #717. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps sentry-ruby from 5.22.1 to 5.22.2.
Changelog
Sourced from sentry-ruby's changelog.
Commits
e357038
release: 5.22.2919df7b
Update README.md (#2515)cceaa6a
Fix issues with specs again (#2514)d9c279b
Use RFC2396_PARSER explicitly to avoid the warning. (#2509)1cd952b
Prevent crashes from get_main_hub when in trap context (#2510)14ef446
Fix issues with specs (#2511)315310f
Improvebefore_send
andbefore_send_transaction
's return value handling (...7fe7f88
Test Ruby 3.4; Upgrade actions workflows versions (#2506)ad535cc
Add Metrics.duration_(start,end) (#2501)bb9ce72
Improve the accuracy of duration calculations in cron jobs monitoring (#2471)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)