Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rstudio): set LANG based on KF_LANG #164

Closed
wants to merge 3 commits into from
Closed

Conversation

wg102
Copy link
Contributor

@wg102 wg102 commented Dec 1, 2020

Related to #149

KF_LANG is planned to be included as an environment variable in the pod when creating the notebook.

@wg102 wg102 linked an issue Dec 1, 2020 that may be closed by this pull request
@blairdrummond
Copy link
Contributor

blairdrummond commented Dec 2, 2020

@wg102 , the output/ folder is generated from the Makefile. You actually want to put this change here

https://github.com/StatCan/kubeflow-containers/blob/master/resources/start-custom.sh

(Then run make all, after you make the edit.)

@wg102 wg102 marked this pull request as draft December 18, 2020 17:26
@sylus
Copy link
Member

sylus commented Dec 26, 2020

Resolves #149 I made the fix and pushed it up

@sylus sylus closed this Dec 26, 2020
@sylus sylus deleted the 149-i18n-rstudio branch December 26, 2020 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add i18n to RStudio (initial elaboration and work)
3 participants