Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Openm++ OMS jupyterlab updates #526

Merged
merged 5 commits into from
Dec 12, 2023
Merged

Openm++ OMS jupyterlab updates #526

merged 5 commits into from
Dec 12, 2023

Conversation

vexingly
Copy link
Contributor

@vexingly vexingly commented Sep 25, 2023 •
edited
Loading

  • Previous code review comments to reduce image size
  • Update logging of oms web-ui to make user accessible
  • Add restart script for oms web-ui

@vexingly vexingly added the auto-deploy Trigger manual CI steps for this PR label Sep 25, 2023
@vexingly vexingly mentioned this pull request Sep 25, 2023
Closed
@chuckbelisle
Copy link

@jacek-dudek & @KrisWilliamson have a look at these changes and let us know what you think or have any questions.

Souheil-Yazji
Souheil-Yazji previously approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@Souheil-Yazji Souheil-Yazji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Souheil-Yazji Souheil-Yazji merged commit 9eed8e8 into master Dec 12, 2023
7 checks passed
@Souheil-Yazji Souheil-Yazji deleted the oms-updates branch December 12, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Souheil-Yazji Souheil-Yazji Souheil-Yazji approved these changes

Assignees
No one assigned
Labels
auto-deploy Trigger manual CI steps for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vexingly @chuckbelisle @Souheil-Yazji