-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(Jupyterlab): Clean-up #544
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ainers into aaw-1855
refactor(docker): clean up #1
fix(cve): force babel/traverse installation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks inoffensive to me, guess we just gotta test it all now
Souheil-Yazji
commented
Oct 30, 2023
Jose-Matsuda
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extensive clean up of the Jupyterlab Images. The remote desktop image was also impacted due to shared dockerbits.
!!!- ALL IMAGES TO BE THOROUGHLY TESTED PRE-MERGE -!!!
ChangeLog
Most of the changes are logged here https://miro.com/app/board/uXjVMj1Jmm4=/
Some major changes that weren't mentioned in the miro board:
mamba
commands without errorRUN ...
commands to reduce layer size, Not that we do use--force-rm
in our docker build command, which forces the removal of intermediate build layers.intial_condarc
file to allow the configuration of conda channels during build-time instead of explicity referencing the conda channels in eachRUN mamba install ...
command -> This might need to be cleaned up in a post-build scriptTests / Quality Checks
SHA: 5bc70e4
-tested cpu, pytorch(cpu), tensorflow(cpu), remote-desktop
Automated Testing/build and deployment
auto-deploy
tag to the PR before pushing in order to build and push the image to ACR so you can test it in cluster as a custom image?JupyterLab extensions
jupyter labextension list
from inside the notebook)? NoVS Code tests
Code review
auto-deploy
tag to your PR before your most recent push to this repo? This causes CI to build the image and push to our ACR, letting reviewers access the built image without having to create it themselvesk8scc01covidacrdev.azurecr.io/jupyterlab-cpu:746d058e2f37e004da5ca483d121bfb9e0545f2b
)?