Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoscaling annotation): add for notebook pods #246

Open
wants to merge 1 commit into
base: kubeflow-aaw2.0
Choose a base branch
from

Conversation

Jose-Matsuda
Copy link

for BTIS-874. Note that we still must fix both kerberos and filer-sidecar since right now they are over-writing annotations.

@Jose-Matsuda Jose-Matsuda added the auto-deploy Trigger manual CI steps for this CI label Mar 6, 2025
@Jose-Matsuda
Copy link
Author

Jose-Matsuda commented Mar 6, 2025

Test Case after this change (but having both filer and kerberos turned off so that the overwrite does not happen)

Starting up an existing notebook
image
image

It wont appear, but for a new notebook it will (or if the statefulset is deleted)
image

I had thought that it would just see the diff in the CopyStatefulSetFields but I guess not.

It might not be able to apply due to;
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-deploy Trigger manual CI steps for this CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant