Skip to content

Commit

Permalink
[CELEBORN-1587] Change to debug logging on client side for SortBasedP…
Browse files Browse the repository at this point in the history
…usher trigger push

### What changes were proposed in this pull request?

Changed a noisy log in SortBasedPusher to debug.

### Why are the changes needed?

Current SortBasedPusher logging is too noisy. It keeps on printing below log many times.

```
SortBasedPusher: Memory used 72.0 MiB exceeds threshold 64.0 MiB, need to trigger push. currentPage size: 64.0 MiB
```

### Does this PR introduce _any_ user-facing change?
NA

### How was this patch tested?
NA

Closes apache#2728 from s0nskar/debug_log_sort_pusher.

Authored-by: Sanskar Modi <[email protected]>
Signed-off-by: mingji <[email protected]>
  • Loading branch information
s0nskar authored and FMX committed Sep 6, 2024
1 parent 29c0f7e commit 9ec345b
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ public boolean insertRecord(
long threshold = pushSortMemoryThreshold;
if (getUsed() > threshold
&& pageCursor + required > currentPage.getBaseOffset() + currentPage.size()) {
logger.info(
logger.debug(
"Memory used {} exceeds threshold {}, need to trigger push. currentPage size: {}",
Utils.bytesToString(getUsed()),
Utils.bytesToString(pushSortMemoryThreshold),
Expand Down

0 comments on commit 9ec345b

Please sign in to comment.