Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(static-classes): add/fix/update css classes #102

Merged
merged 1 commit into from
May 24, 2024

Conversation

jessebofill
Copy link
Contributor

This changes to finding modules by searching from only the class modules instead of all modules and fixes 2 wrong class modules being found. Additionally more classes are added as well as all type definitions updated with the latest classes.

@TrainDoctor TrainDoctor added the enhancement New feature or request label Mar 19, 2024
Copy link
Member

@AAGaming00 AAGaming00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very clean pr, just needs testing. thanks for the contribution!

@jessebofill
Copy link
Contributor Author

Thanks. Sounds good.

@FrogTheFrog
Copy link
Contributor

Any progress on getting this merged? The Decky v2.12.0 has the broken static-classes in stable.

@TrainDoctor
Copy link
Member

Experienced issues with injecting into the UI when testing this. Will need to test on Stable as testing on beta yielded breakage.

@jessebofill
Copy link
Contributor Author

Experienced issues with injecting into the UI when testing this. Will need to test on Stable as testing on beta yielded breakage.

Can you test this again. I'm not sure what the problem could be.

@jessebofill
Copy link
Contributor Author

Ok it looks like the prop that was used to find MainMenuAppRunningClasses was removed and thus it was returning undefined. I fixed that as well as updated the other classes. so this should be good now.

@jessebofill jessebofill changed the base branch from main to v4-dev May 23, 2024 19:28
Copy link
Member

@AAGaming00 AAGaming00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@AAGaming00 AAGaming00 merged commit 86e6e4c into SteamDeckHomebrew:v4-dev May 24, 2024
1 check failed
Copy link

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants