-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(static-classes): add/fix/update css classes #102
chore(static-classes): add/fix/update css classes #102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very clean pr, just needs testing. thanks for the contribution!
Thanks. Sounds good. |
Any progress on getting this merged? The Decky v2.12.0 has the broken static-classes in stable. |
Experienced issues with injecting into the UI when testing this. Will need to test on Stable as testing on beta yielded breakage. |
Can you test this again. I'm not sure what the problem could be. |
Ok it looks like the prop that was used to find MainMenuAppRunningClasses was removed and thus it was returning undefined. I fixed that as well as updated the other classes. so this should be good now. |
f9017cf
to
982c553
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
🎉 This PR is included in version 4.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This changes to finding modules by searching from only the class modules instead of all modules and fixes 2 wrong class modules being found. Additionally more classes are added as well as all type definitions updated with the latest classes.