-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Security component documentation for v4 #326
Conversation
Preview link: https://docs-steeltoe-pr-326.azurewebsites.net
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, to the point, and well explained.
Overall looks good, I've provided feedback on minor details.
Regarding certificates, do we need to mention it only works with https, if that's the case? |
Co-authored-by: Bart Koelman <[email protected]>
The https restriction is Microsoft's, as is support for HTTP 2 and 3. Our sample still works if configured for http2-only or http3-only. While I don't expect Microsoft to remove the https restriction, since these items are not in our control (and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See feedback.
Co-authored-by: Bart Koelman <[email protected]>
also resolves #11 and resolves #52