V4 Updates for Metrics, Tracing and Security #336

TimHess · 2025-01-03T21:27:50Z

Addresses the remaining parts of #317.

github-actions · 2025-01-03T21:40:59Z

Preview link: https://docs-steeltoe-pr-336.azurewebsites.net

Your changes have been deployed to the preview site. The preview site will update as you add more commits to this branch.
The preview link is shareable, but will be deleted when the pull request is merged or closed.

This is an automated message.

bart-vmware

Just a few things that caught my eye while reading through the pages. I haven't done a thorough review yet.

api/v4/management/metrics.md

api/v4/management/prometheus.md

api/v4/security/sso-open-id.md

bart-vmware

Added some initial feedback, I need more time to dive into this.

api/v4/management/metrics.md

api/v4/management/prometheus.md

api/v4/security/jwt-bearer.md

api/v4/bootstrap/index.md

bart-vmware

Publishing accumulated feedback at the end of my day, I haven't looked at all files yet.

api/v4/security/certificate.md

api/v4/management/prometheus.md

api/v4/security/sso-open-id.md

api/v4/security/jwt-bearer.md

api/v4/management/prometheus.md

api/v4/management/metrics.md

api/v4/security/certificate.md

api/v4/management/metrics.md

api/v4/security/certificate.md

api/v4/security/jwt-bearer.md

api/v4/security/redis-key-storage-provider.md

api/v4/tracing/index.md

api/v4/management/prometheus.md

bart-vmware

All I did was paste the suggested code in an empty project, without running or deploying anything. Doing just that doesn't even work. Please verify that what's documented can actually be used as described; verify the code compiles and runs, both locally and in Cloud Foundry.

Please do so for tracing, redis, certificates, JWT, OpenID and Prometheus. The other pages are already fine.

api/v4/tracing/index.md

api/v4/security/redis-key-storage-provider.md

api/v4/tracing/index.md

Co-authored-by: Bart Koelman <[email protected]>

api/v4/tracing/index.md

api/v4/management/prometheus.md

Co-authored-by: Bart Koelman <[email protected]>

api/v4/tracing/index.md

api/v4/welcome/whats-new.md

api/v4/management/prometheus.md

api/v4/security/certificate.md

api/v4/security/sso-open-id.md

api/v4/security/jwt-bearer.md

Co-authored-by: Bart Koelman <[email protected]>

api/v4/security/jwt-bearer.md

api/v4/security/certificate.md

Co-authored-by: Bart Koelman <[email protected]>

* Update Cloud Foundry actuator/integration --------- Co-authored-by: Bart Koelman <[email protected]>

TimHess self-assigned this Jan 3, 2025

bart-vmware reviewed Jan 6, 2025

View reviewed changes

TimHess marked this pull request as ready for review January 7, 2025 20:21

TimHess requested a review from bart-vmware January 8, 2025 15:04

TimHess mentioned this pull request Jan 8, 2025

ShowDetails in /health SteeltoeOSS/Steeltoe#1421

Merged

5 tasks

This comment was marked as resolved.

Sign in to view

bart-vmware reviewed Jan 9, 2025

View reviewed changes

api/v4/management/metrics.md Outdated Show resolved Hide resolved

api/v4/management/metrics.md Outdated Show resolved Hide resolved

api/v4/management/prometheus.md Outdated Show resolved Hide resolved

bart-vmware reviewed Jan 14, 2025

View reviewed changes

api/v4/security/jwt-bearer.md Show resolved Hide resolved

bart-vmware reviewed Jan 14, 2025

View reviewed changes

api/v4/bootstrap/index.md Show resolved Hide resolved

bart-vmware reviewed Jan 14, 2025

View reviewed changes

bart-vmware mentioned this pull request Jan 16, 2025

Update Documentation for v4 #317

Closed

10 tasks

TimHess force-pushed the Tim/contentupdates branch from 0e32e0e to 1fd5979 Compare January 30, 2025 19:08

TimHess mentioned this pull request Jan 30, 2025

Prefer "org" to spelling out "organization" SteeltoeOSS/Steeltoe#1452

Merged

5 tasks

TimHess requested a review from bart-vmware January 30, 2025 23:13

bart-vmware reviewed Feb 4, 2025

View reviewed changes

TimHess force-pushed the Tim/contentupdates branch from 0320078 to fd9fa58 Compare February 5, 2025 14:18

TimHess requested a review from bart-vmware February 5, 2025 14:18

TimHess force-pushed the Tim/contentupdates branch 3 times, most recently from 8fe28b5 to ee79f1f Compare February 11, 2025 15:41

bart-vmware requested changes Feb 11, 2025

View reviewed changes

api/v4/security/certificate.md Show resolved Hide resolved

TimHess requested a review from bart-vmware February 11, 2025 17:00

bart-vmware mentioned this pull request Feb 12, 2025

Update [Authorize] in security sample SteeltoeOSS/Samples#374

Closed

bart-vmware reviewed Feb 12, 2025

View reviewed changes

api/v4/management/prometheus.md Outdated Show resolved Hide resolved

TimHess force-pushed the Tim/contentupdates branch from 8b14b1b to 792eafc Compare February 18, 2025 16:06

TimHess requested a review from bart-vmware February 18, 2025 19:48

bart-vmware requested changes Feb 20, 2025

View reviewed changes

TimHess and others added 9 commits February 20, 2025 18:04

review security samples again

ed36b98

update all samples links from latest to main

3c616c4

polish tracing

07063c4

revert what's new link changes to avoid conflict

887fe54

polish prometheus

124ac3b

Apply suggestions from code review

951bebf

Co-authored-by: Bart Koelman <[email protected]>

Apply suggestions from code review

a75843e

Co-authored-by: Bart Koelman <[email protected]>

Update api/v4/tracing/index.md

9627531

Co-authored-by: Bart Koelman <[email protected]>

address feedback

accfb90

TimHess force-pushed the Tim/contentupdates branch from ce711d7 to accfb90 Compare February 21, 2025 00:04

bart-vmware requested changes Feb 21, 2025

View reviewed changes

api/v4/tracing/index.md Show resolved Hide resolved

api/v4/tracing/index.md Show resolved Hide resolved

api/v4/tracing/index.md Outdated Show resolved Hide resolved

api/v4/management/prometheus.md Show resolved Hide resolved

TimHess and others added 2 commits February 21, 2025 08:07

Update api/v4/tracing/index.md

9fd2893

Co-authored-by: Bart Koelman <[email protected]>

fix tracing rendering issue, add prometheus output and semicolons

e1ab064

TimHess requested a review from bart-vmware February 21, 2025 14:20

TimHess added 2 commits February 21, 2025 14:38

further enhance SSO docs

7e457b4

tracing usings and a note about first entry not being the end

f6447d0

bart-vmware requested changes Feb 26, 2025

View reviewed changes

TimHess and others added 2 commits February 26, 2025 08:48

Apply suggestions from code review

c15a808

Co-authored-by: Bart Koelman <[email protected]>

address feedback

8f06a79

TimHess requested a review from bart-vmware February 26, 2025 17:43

reset whats-new

5aa4c35

bart-vmware reviewed Feb 26, 2025

View reviewed changes

api/v4/security/jwt-bearer.md Outdated Show resolved Hide resolved

api/v4/security/certificate.md Outdated Show resolved Hide resolved

TimHess and others added 2 commits February 26, 2025 14:19

heavier emphasis on adding cf config ref

867310a

Apply suggestions from code review

002e1f7

Co-authored-by: Bart Koelman <[email protected]>

TimHess requested a review from bart-vmware February 26, 2025 20:21

bart-vmware approved these changes Feb 26, 2025

View reviewed changes

TimHess merged commit 50d5ff8 into v4 Feb 26, 2025
5 checks passed

TimHess deleted the Tim/contentupdates branch February 26, 2025 20:35

bart-vmware added a commit that referenced this pull request Feb 26, 2025

V4 Updates for Metrics, Tracing and Security (#336)

7437b0c

* Update Cloud Foundry actuator/integration --------- Co-authored-by: Bart Koelman <[email protected]>

bart-vmware restored the Tim/contentupdates branch February 26, 2025 21:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V4 Updates for Metrics, Tracing and Security #336

V4 Updates for Metrics, Tracing and Security #336

TimHess commented Jan 3, 2025 •

edited by bart-vmware

Loading

github-actions bot commented Jan 3, 2025

bart-vmware left a comment

This comment was marked as resolved.

bart-vmware left a comment

bart-vmware left a comment

bart-vmware left a comment

V4 Updates for Metrics, Tracing and Security #336

V4 Updates for Metrics, Tracing and Security #336

Conversation

TimHess commented Jan 3, 2025 • edited by bart-vmware Loading

github-actions bot commented Jan 3, 2025

Preview link: https://docs-steeltoe-pr-336.azurewebsites.net

bart-vmware left a comment

Choose a reason for hiding this comment

This comment was marked as resolved.

bart-vmware left a comment

Choose a reason for hiding this comment

bart-vmware left a comment

Choose a reason for hiding this comment

bart-vmware left a comment

Choose a reason for hiding this comment

TimHess commented Jan 3, 2025 •

edited by bart-vmware

Loading