-
-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PrintSky plugin #1008
base: master
Are you sure you want to change the base?
PrintSky plugin #1008
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hmm... Should we merge this PR into master and propose users to testing? |
Hmm, this was so far just a fast port to make it work again. We should put some more effort into it before public testing, or else we get the most obvious points as feedback, see (edited) feature proposal checklist in the description. Maybe we can implement at least some of these by ~ September 5, then merge and run for public testing? There are traces of "dynamic plugin" still in here. Maybe experiment to revive that idea? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Some points from the list look strange to me (and it was strange since the birthday of plugin) - for example we shot some part of the sky and attached ephemerides of Solar system objects, but these parts are not related together. We can get a situation, when a screenshot will have no one solar system object.
I guess the screenshot should be with an equatorial grid to allow users to navigate on the printed map (on the other hand it will be not very good for dobsonian telescopes owners). Plus we can add some magic to remove halo around stars and replace color of the sky on the screenshots to get a map, similar to map from atlases. Maybe we should ask potential users on the forums like Cloudy Nights and Stargazers Lounge?
See QVector Ephemeris List and Ephemeris struct - we can attach an ephemeris of object (or few objects), if those data are calculated. See: STELLARIUM REPORT.pdf and STELLARIUM REPORT inverted.pdf
See https://github.com/Stellarium/stellarium-dynamic-plugin - it works on linux, but I fear it will not work for Windows |
The ephemeris is an optional element. I added a place for "information about the currently selected object", but it does not show anything yet. I think it should be easy to output InfoString here (Maybe even something else, later), but I don't know yet how to manage a pagebreak or pretty-print HTML. Of course, this should be printed only if there is a selection.
This would require changes in the screenshot creation. You can set the screen background color (light-blue background if you prefer?), and certainly plain round white stars. But this is not even urgent, IMHO. I would leave selection of grids and most other choices about the screenshot appearance to the user. But probably we must force a screenshot size or dimensions to fit image and text on one layout, and we must combine landscape/portrait, and when Qt has the options, should probably support A4 and letter paper. It is possible that the star magnitude scale and any rescaled screenshot currently don't fit together. We need to experiment with manually scaled screenshots e.g. at the usual scale of 72 pixels/inch. (Maybe go to 144 or 216px/in and scale star mag scale instead?)
If there is a developer there, who knows himself what best to develop? Else you are asking for more work.
Of course the ephemeris curve plotted in the map can be shown. I meant e.g. curves like magnitude and diameter over a whole year. There may be several modes of reports which we could specify before we implement more:
See StelDialogPrintSky.hpp, it mentions Windows explicitly. I have no time today, maybe in the evening. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@alex-w please we should rebase this branch from master, not merge master, to have a cleaner history. Basically, while a branch is draft, this should be necessary only when then some progress can be expected. |
Sorry, but I've resolve conficls through web interface and he cannot do rebase... :-/ |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
- does not work completely yet, but compiles.
- Move properties from dialog to main plugin class - UI needs changes
- Allow screenshot retrieval - Add test if planet hidden
- preview and printing works - page margins could need improvement - improved table column widths
- limit magnitudes - selected object info (switch only. printing TBD) and a few minor style corrections. Marked (FIXME) places for the next improvements.
- Exclude comets far from perihel - A little GUI improvement
Currently super fragile and crashes. Better "amend" next commit.
- crashes on second run - preview fontsize smaller than print fontsize
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This is a rebased reactivation of Pep Pujol's PrintSky plugin which had been abandoned in 2010.
Description
I have rebased the PrintSky branch left abandoned in 2010. It was still on Qt4, so I updated necessities to Qt5 and (2022) to Qt6, property handling etc.
After all, a printed report (PDF or real printer) can become helpful.
However, we currently don't really know what a "printed report from Stellarium" should look like. I therefore invite fellow developers to come forth with an idea, maybe an "astro club information sheet" for street astronomy of "what to see tonight", or anything else. Maybe a solution with a few templates. Usually we just make screenshots and embed them in other documents.
Fixes #410 (issue)
Currently preview works, but storing to PDF crashes. Page layout is a mess. It really needs a thorough redesign.
New Features checklist
Before merge, IMHO at least most of these should be done. Please feel free to add more (reasonable) ideas.
Screenshots (if appropriate):
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: