-
-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote control command to change window size #3433
Conversation
- Also via scripting
- also follow Qt recommendations w.r.t. nullptr and override.
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
The style cleanup ( |
The whole thing is just a tiny little extra function. And as before, while doing something in a plugin, I change those override etc. keywords. Disentangling that into an extra commit, and squashing the Cleanup commit into the previous, is IMO a needless hassle. |
Well, the point of disentangling is to make it truly separate, not to squash it. In fact, it wasn't even related to this PR so could be just pushed independently. And now anyone who gets pointed to this commit, say, by git-bisect, will have to study all these irrelevant diff hunks just to find the parts comprising the core of the change. |
Hello @gzotti! Please check the fresh version (development snapshot) of Stellarium: |
Hello @gzotti! Please check the latest stable version of Stellarium: |
This provides
The main reason is interoperability with a program that utilizes Stellarium's Spout output.
The window size is no property that would else be synchronized over screens of different sizes.
Description
Fixes # (issue)
Screenshots (if appropriate):
Type of change
How Has This Been Tested?
Script:
core.setWindowSize(1200, 850);
RemoteControl API:
curl -d 'w=2300&h=800' http://localhost:8090/api/main/window
Test Configuration:
Checklist: