Make objects split by cylinder projections wraparound appear on one side of the screen #3438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
gzotti
reviewed
Oct 1, 2023
gzotti
added
enhancement
…ide of the screen Some projections expand azimuth dimension over the width of the screen. This makes objects that are clipped by a side of the screen appear on the other side. But currently these objects remain single objects, which results in stretching over the whole distance between one side of the projection to the other. This commit improves on this situation by making it possible to put an object completely on one side of the screen — the one where object's center resides. This loses the second half that should appear on the opposite side of the screen, but at least avoids the stretching artifacts. Currently this is only applied to Cylinder projection and its derivatives. Others may be tweaked similarly in subsequent commits.
10110111
force-pushed
the
one-sided-projection
branch
from
91361b3 to
3dff972
Compare
alex-w
added
the
state: published
|
Hello @10110111! Please check the fresh version (development snapshot) of Stellarium: |
alex-w
removed
the
state: published
|
Hello @10110111! Please check the latest stable version of Stellarium: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some projections expand azimuth dimension over the width of the screen. This makes objects that are clipped by a side of the screen appear on the other side. But currently these objects remain single objects, which results in stretching over the whole distance between one side of the projection to the other.
This commit improves on this situation by making it possible to put an object completely on one side of the screen — the one where object's center resides. This loses the second half that should appear on the opposite side of the screen, but at least avoids the stretching artifacts.
Currently this is only applied to Cylinder projection and its derivatives. Others may be tweaked similarly in subsequent commits.
Fixes #3437
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: