Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No need for ATL headers since it's not being used #3444

Merged
merged 1 commit into from
Oct 4, 2023
Merged

No need for ATL headers since it's not being used #3444

merged 1 commit into from
Oct 4, 2023

Conversation

hmartinez82
Copy link
Contributor

@hmartinez82 hmartinez82 commented Oct 4, 2023 •
edited
Loading

Description

ATL headers were added, but not used. Only regular COM is being used and some OLE, but it is already included by ../common/OLE.hpp

Fixes

Building in environments where ATL headers are not available.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

Built with Visual Studio
Windows 11 x64

Test Configuration:

  • Operating system: Windows 11 x64 10.0.22621.2361

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes

@github-actions github-actions bot requested review from 10110111, alex-w and gzotti October 4, 2023 03:35
github-actions[bot]
github-actions bot reviewed Oct 4, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding your first pull request to Stellarium. If you have questions, please do not hesitate to contact us.

alex-w
alex-w approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alex-w alex-w added this to the 23.4 milestone Oct 4, 2023
@alex-w alex-w merged commit d28ff56 into Stellarium:master Oct 4, 2023
11 checks passed
@hmartinez82 hmartinez82 deleted the NoNeedForATL branch October 4, 2023 04:17
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Oct 23, 2023
@github-actions
Copy link

Hello @hmartinez82!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Dec 23, 2023
@github-actions GitHub Actions
Copy link

Hello @hmartinez82!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@alex-w alex-w alex-w approved these changes

@10110111 10110111 Awaiting requested review from 10110111

@gzotti gzotti Awaiting requested review from gzotti

Assignees

@hmartinez82 hmartinez82

Labels
None yet
Milestone
23.4
Development

Successfully merging this pull request may close these issues.
2 participants
@hmartinez82 @alex-w