-
-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dpiAwareness option to manifest and send physicial viewport size to Spout #3462
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
89e9881
to
d2cc9c8
Compare
Hello @hmartinez82! Please check the fresh version (development snapshot) of Stellarium: |
Hello @hmartinez82! Please check the latest stable version of Stellarium: |
Qt 6 defaults to PerMonitorV2 as its DPI awareness options.
Description
The ACCESS_DENIED error was happening because the setting was being set by the manifest file and then, when the QGuiApplication instance is being created, it calls
SetProcessDpiAwarenessContext()
which clearly states that setting that after the manifest also sets it will lead to ACCESS_DENIED.Adding the options before Qt tries to set it ensures it won't try to call SetProcessDpiAwarenessContext() because the process will already be PerMonitorV2. (Qt checks the current options before trying to change it, see https://github.com/qt/qtbase/blob/v6.5.3/src/plugins/platforms/windows/qwindowscontext.cpp#L397)
Fixes #3461
Type of change