Remove unused global scaling ratio #3463
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
|
Another approach may be to get rid of the direct use of the device pixel ratio, replacing it with this global scaling factor, and set this factor to the device pixel ratio at the initialization. This would let us roll out a custom way of handling scaling (which I actually would like to implement, because Qt's implementation sucks with its various artifacts and other shortcomings). |
|
This scaling problem is super annoying. If this global scaling ratio is never used, sure, get rid of it. Else, take care to keep scaling working on all 3 systems with all current flavours (W7/10/11; X11/wayland [does it make a difference?]; whateverMacDoes; see Qt docs and how Qt5/6 evolves to accommodate OS changes), and also take care of multi-screen setups with screens at potentially different scaling ratios. I am confined to one (large) screen where 125% is recommended, so am not too much help on difficult cases. Can test (W10/W11)+WSL(U22.04) though. |
Does Windows support virtual splitting similar to FakeXRandR? Your help will definitely be needed, because I don't have any Windows newer than 7. |
|
I know roughly about xrandr, but not about fakes. What would virtual splitting do? |
It creates fake outputs, simulating several smaller monitors covering the viewport of your single large one. So you could e.g. maximize a window, and it would only expand to, say, a third of the total screen space, and then you can do the same for other windows on other virtual monitors. |
|
Windows does have something like screen splitting where you can assemble 2-6 windows in a regular split pattern. But then you can drag the borders between those regions. I sometimes test things on 2 or 3 instances connected via RemoteSync, or run one Stellarium window plus a webbrowser for RemoteControl. The screen scaling would still globally apply to the physical screen. |
alex-w
added
the
state: published
|
Hello @10110111! Please check the fresh version (development snapshot) of Stellarium: |
alex-w
removed
the
state: published
|
Hello @10110111! Please check the latest stable version of Stellarium: |
This notion was introduced in 2013 in c3742e3, and the corresponding setter is never called. Given the current support for HiDPI scaling via the Qt-supplied mechanism of device pixel ratio and lack of the query of the global scaling ratio in many cases where the pixel ratio is queried, I think this global scaling needlessly complicates the logic, so should be removed.