Make keyboard modifiers for mouse motions exact #3468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
gzotti
reviewed
Oct 22, 2023
Before this commit one could set a custom marker with e.g. Shift+Ctrl modifier, which contaminates such combos rendering them impossible to use for other purposes. Now the modifier is fixed to exactly Shift, without any other keys pressed, so e.g. Shift+Ctrl+click doesn't set a custom marker, while Shift+click does.
10110111
force-pushed
the
exact-modifiers
branch
from
0cdf0a0 to
10ad2b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently one can set a custom marker with e.g. Shift+Ctrl modifier, which contaminates such combos rendering them impossible to use for other purposes. These commits make the modifiers exact, i.e. for custom markers no keys except Shift must be pressed, so e.g. Shift+Ctrl+click doesn't set a custom marker, while Shift+click does. Similarly for time dragging: only Ctrl triggers it, not when other modifiers are pressed.
Type of change