Remove fixed sizes from Config dialog .ui file #3489
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the sizes are replaced with normal QLayout-based positioning, and a few more essential ones are moved into normalStyle.css for greater flexibility in customization.
This change is required to make it possible to resize the whole GUI when font size changes. Such scaling will let us go away from the Qt's kludge of virtual pixels, whose problem is not only that it's a kludge leading to inconsistencies in the code, but also that it leads to some blurring of text in particular situations and coarsening of mouse input events.
I tried to preserve the look of the dialog as much as possible, with one exception: the sizes of
scriptListWidget
are configured similarly to those ofpluginsListWidget
, so that the split between the list and the description panels is not in the middle, but on the left side, see the screenshots below.I'm going to change some other dialogs in a similar way, and add a function that will multiply all pixel-based sizes in
normalStyle.css
by a scale factor. To make it all work, I propose some rules that will help maintain scalability of the GUI:QLayout
classes, in particular,QGridLayout
is quite good for this;pluginsListWidget
), do it vianormalStyle.css
. This will keep these values accessible to the code that will be able to adjust them as required.Old Scripts tab
New Scripts tab