Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scale the pixel sizes in the stylesheet according to GUI font size #3490

Merged
merged 2 commits into from
Nov 4, 2023
Merged

Scale the pixel sizes in the stylesheet according to GUI font size #3490

merged 2 commits into from
Nov 4, 2023

Conversation

10110111
Copy link
Contributor

@10110111 10110111 commented Nov 3, 2023

This is another step into the direction of scaling the GUI without kludges. The style itself is still not perfect (namely, the spacing is not scaled yet), but this is already an improvement, see the following screenshots.

Original 2× font size

Screenshot_2023-11-03_11-28-57

This PR 2× font size

Screenshot_2023-11-03_11-29-50

Original 1× font size at 200% via Qt scale factor

Screenshot_2023-11-03_11-31-32

Original 1.5× font size

Screenshot_2023-11-03_11-39-00

This PR 1.5× font size

Screenshot_2023-11-03_11-38-14

Original 1× font size at 150% via Qt scale factor

Screenshot_2023-11-03_11-37-24

@github-actions github-actions bot requested review from alex-w and gzotti November 3, 2023 07:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

@alex-w alex-w added this to the 23.4 milestone Nov 3, 2023
gzotti
gzotti approved these changes Nov 4, 2023
View reviewed changes
Copy link
Member

@gzotti gzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok, thanks!

@10110111
Copy link
Contributor Author

10110111 commented Nov 4, 2023

Just noticed a blocker, posted here. You can see the problem in Surveys list in the View dialog.

@10110111
Copy link
Contributor Author

10110111 commented Nov 4, 2023

I added a workaround that will prevent scaling of QListView indicators, so that the text is still fully legible. This doesn't look great, but legibility is more important than prettiness, so this will do for now.

@10110111 10110111 merged commit 491461b into Stellarium:master Nov 4, 2023
9 checks passed
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Nov 5, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2023

Hello @10110111!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Dec 23, 2023
@github-actions GitHub Actions
Copy link

Hello @10110111!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzotti gzotti gzotti approved these changes

@alex-w alex-w alex-w approved these changes

Assignees

@10110111 10110111

Labels
None yet
Milestone
23.4
Development

Successfully merging this pull request may close these issues.
3 participants
@10110111 @alex-w @gzotti