Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct screen when making a screenshot #3532

Merged

Conversation

10110111
Copy link
Contributor

@10110111 10110111 commented Dec 4, 2023

Current code picks a screen based only on the size of the scene, ignoring the position of the window. Asking the widget for its screen is the proper way of doing this.

Fixes #3527

Copy link

github-actions bot commented Dec 4, 2023

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

Current code picks a screen based only on the size of the scene,
ignoring the position of the window. Asking the widget for its screen
is the proper way of doing this.
@10110111 10110111 force-pushed the fix-choosing-screen-for-screenshot branch from 30f0d72 to fc45042 Compare December 5, 2023 08:09
@alex-w alex-w added this to the 23.4 milestone Dec 5, 2023
Copy link
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least on my Retina Mac it works as expected

@10110111 10110111 merged commit 787c806 into Stellarium:master Dec 5, 2023
11 of 12 checks passed
@10110111 10110111 deleted the fix-choosing-screen-for-screenshot branch December 5, 2023 08:59
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Dec 10, 2023
Copy link

Hello @10110111!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Dec 23, 2023
Copy link

Hello @10110111!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Crash when screenshoting
2 participants