[feat] : Card 컴포넌트 기능 보완 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 중앙 매칭완료 문구 추가 필요 - 매칭 여부에 따라 배경색, 마감기한 색상, 화살표 색상, 마우스 커서 모양 동적으로 변경
baegyeong
approved these changes
Oct 6, 2023
| <div className="w-80 h-20 rounded-xl border-[#8B8B8B] border my-4 py-2 px-3 flex justify-between"> | ||
| <div | ||
| className={`w-80 h-20 rounded-xl border-[#8B8B8B] border m-auto my-[15px] | ||
| ${match ? 'bg-[#000000]/50' : ''}`} |
There was a problem hiding this comment.
#000000은 그냥 bg-black으로 해도 잘 들어갈 것 같아요~! 그 외의 색상들도 tailwind.config.js에 지정해둬서 쓰면 편리할 것 같습니다!! 🙂🙂
| className={`w-80 h-20 rounded-xl border-[#8B8B8B] border m-auto my-[15px] | ||
| ${match ? 'bg-[#000000]/50' : ''}`} | ||
| > | ||
| <Link to={match ? './' : to} className={`flex justify-between py-2 px-3 ${match ? 'cursor-default' : ''}`}> |
There was a problem hiding this comment.
match가 true일 때 아무것도 렌더링하고 싶지 않은 걸 의도하신 걸까요?
그걸 의도한 게 아니고 한 값이 '' 이런 식이라면 삼항연산자 대신 &&로 해도 좋을 것 같아요..!
There was a problem hiding this comment.
match가 true일 때는 시각적으로 '아 이 공고는 매칭됬구나' 를 알리기 위해 bg-[#000000]을 적용했고, false일 경우에는 아무것도 적용시키지 않기 위해서 '' 형태로 남겨두었습니다!
| <div> | ||
| <div className="flex items-center"> | ||
| <MdOutlineLocationOn className="mr-1" style={{ color: '#0075FF' }} /> | ||
| {orderLocation} | ||
| </div> | ||
| <BsArrowDown style={{ color: '8B8B8B' }} /> | ||
| <BsArrowDown style={arrowColor} /> |
There was a problem hiding this comment.
👍🏻미리 선언하고 match 여부에 따라 쓰니 깔끔하네요~! 배워갑니다...
There was a problem hiding this comment.
리뷰 코멘트 읽다보니 위에 공고글 전체 배경색을 match에 따라 동적으로 넣는 부분도 이런식으로 변경하면 좋겠다는 생각이 문득 들었네요!! 나중에 한 번 고쳐보도록 하겠습니다 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 타입(하나 이상의 PR 타입을 선택해주세요)
작업 사항
관련 이슈