This repository has been archived by the owner on Feb 16, 2023. It is now read-only.
Es solr support 12 #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pagination fix when using faceted search
Fixing setting correct parameters for paging links
Adding changed placeholder prefix to readme
Add all placeholders to noresults tpl
…ation-fix Pagination fix when using faceted search
…-params Fixing setting correct parameters for paging links
FIX: Pagination Next and Last links
FIX: Bad characters in extract due to preg_replace with php 7.0 and l…
Merge PR's into development
Development
|
Hi @travisbotello , Just jumping in to this repo to help maintain. I used to work for MODX and have implemented SimpleSearch countless times. I noticed you've contributed some work to this project in the past already—thank you so much :) Question—and please excuse me if I'm mistaken because I haven't looked at the code very much lately—does it seem like this PR is a bit outdated? Why I ask is that the version number in Also just to confirm the main goal of this PR is to update both ES and Solr support, is that correct? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.