Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: changed setting to boolean for vertex colors and alpha blending… #211

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

LKAMinco
Copy link
Contributor

@LKAMinco LKAMinco commented May 4, 2024

Changed Alpha Blending settings from Blender material option to user options. For now it is under shader, because there is no better place.

Changed exporting setting for vertex colors instead of default always export v.colors, now user have check box. -> Main reason is that some of the addons are using v.colors for operations, so model can have v.colors and will be exported even when it is not necessary.

@StjerneIdioten
Copy link
Owner

Changed Alpha Blending settings from Blender material option to user options. For now it is under shader, because there is no better place.

Why can't it just be in a panel on the material itself, just like the panels that exist on other objects? I know there currently isn't one, but that is mostly just because most things already existed to be pulled from the material settings or happens in the node editor

Changed exporting setting for vertex colors instead of default always export v.colors, now user have check box. -> Main reason is that some of the addons are using v.colors for operations, so model can have v.colors and will be exported even when it is not necessary.

Like operations in Blender, where you don't actually want the v colors exported to your i3d model?

Also common for both of these changes is that this would actually break existing models right? So we either make it a breaking change to signify some user action (and write it in the changelog) or figure out a way to automatically update the file to fit the new locations of parameters.

@LKAMinco
Copy link
Contributor Author

LKAMinco commented May 5, 2024

Why can't it just be in a panel on the material itself, just like the panels that exist on other objects? I know there currently isn't one, but that is mostly just because most things already existed to be pulled from the material settings or happens in the node editor

Simply, because I have not want to create panel just for one setting, Maybe Shader picker panel can be renamed jsut to material and shader setting can be collapsed panel in material panel, which can be now done in one drawing since Blender 4.1 added so called "Layout Panels", which can be directly created under panel.

Like operations in Blender, where you don't actually want the v colors exported to your i3d model?

Yes, e.g. older version of uv packmaster were using vertex colors for storing data for uv, like rotation step, or groups.

Also common for both of these changes is that this would actually break existing models right? So we either make it a breaking change to signify some user action (and write it in the changelog) or figure out a way to automatically update the file to fit the new locations of parameters.

Yes, probably make it breaking change, would make more sense, since there is no better solution how to check whether user wants to export vertex colors or not. And since this will be breaking change, then alpha blending can be also.

@StjerneIdioten
Copy link
Owner

StjerneIdioten commented Jun 11, 2024

Simply, because I have not want to create panel just for one setting, Maybe Shader picker panel can be renamed jsut to material and shader setting can be collapsed panel in material panel, which can be now done in one drawing since Blender 4.1 added so called "Layout Panels", which can be directly created under panel.

I like that solution a lot better. I did notice the new panel type, which is a lot nicer than have to create a whole new panel class for every little thing 😉

Yes, probably make it breaking change, would make more sense, since there is no better solution how to check whether user wants to export vertex colors or not. And since this will be breaking change, then alpha blending can be also.

I can also bump the Blender version supported at the same time, since I consider that a "breaking change" to 😉 I also need to have a look at the new way add-ons are supposed to be packed as well. I think it is destined to land in Blender 4.2.

Sorry for the late answer, but I thought I had already answered 😅

@StjerneIdioten
Copy link
Owner

StjerneIdioten commented Nov 29, 2024

Would this PR be incompatible with the latest changes now? Given that vertex colors have changed to color data etc.

@LKAMinco
Copy link
Contributor Author

Probably, i will update this, with new update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants