Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strategies POC #156

Closed
wants to merge 1 commit into from
Closed

Strategies POC #156

wants to merge 1 commit into from

Conversation

beshur
Copy link
Member

@beshur beshur commented Dec 4, 2019

No description provided.

@beshur beshur changed the base branch from develop to content-refactoring December 4, 2019 19:57
@beshur beshur requested a review from endway December 4, 2019 19:57
endway
endway approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@endway endway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :)
Maybe we should keep control/status of the same type (i.e. onOfTheVideos) in the same file.
That may help us while debugging, as strategies may have similar logic, selectors.

@beshur
Copy link
Member Author

beshur commented Dec 4, 2019

Clean branch #157

@beshur beshur closed this Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endway endway endway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beshur @endway