Fix for STS-912 #64
Open
Fix for STS-912 #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should fix STS-912.
We ran into the bug on Weblogic 12 and I invested some time to investigate and fix this issue. For better testing I moved the inner class MyServletOutputStream.
The reason for the bug is, that for some reason bbuf.remaining() is returning 0 and so the for loop ends up in an infinity loop. This is somehow connected to characters with code < 0, because only with those characters I was able to reproduce this and only for some numbers of special characters, that's why there are tests for 632 and 633 of those characters.
The only real change is in MyServletOutputStream.write.