This repository has been archived by the owner on Mar 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
[Feat] 회원은 투표하지 못한 투표 목록을 조회할 수 있어야 한다. #164
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: - 회원이 메인페이지에서 본인이 투표하지 못한 목록을 조회할 수 있어야 한다는 추가된 요구사항을 받았습니다. modification: - 해당 기능 추가 note: - 간단한 URL로 설정을 했는데 나중에 쿼리 파라미터들로 조회 URL들을 합칠 예정입니다. Close #163
Test Results48 tests ±0 48 ✅ ±0 2s ⏱️ ±0s Results for commit 4acd3ca. ± Comparison against base commit aaa0bf5. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
NoJaeHyuk
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다~
happymink
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!
laigasus
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다!
코멘트 남겼습니다 🙇
app/src/main/java/fc/be/app/domain/vote/controller/VoteControllerImpl.java
Outdated
Show resolved
Hide resolved
app/src/main/java/fc/be/app/domain/vote/service/service/VoteInfoQueryService.java
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경사항
modification:
note:
Issue Link - #163