Skip to content
This repository has been archived by the owner on Mar 26, 2024. It is now read-only.

[Refactor/Fix] Wish 엔드포인트 조정 및 부분 오류 수정 #176

Merged
merged 5 commits into from
Jan 24, 2024

Conversation

laigasus
Copy link
Member

@laigasus laigasus commented Jan 24, 2024

변경사항

# 찜 추가 엔드포인트의 body 값이 변경되었습니다.(body로 받는 memberId 를 UserPrincipal 로 대체)
# 찜 삭제시 고정되어있던 memberId 값 수정

Issue Link - #175

체크리스트

리뷰 요청 전에 확인해야 할 사항들을 나열해주세요.

  • 변경 후 코드가 잘 동작하나요?

참고

스크린샷 2024-01-24 175008
스크린샷 2024-01-24 175030
스크린샷 2024-01-24 175201
스크린샷 2024-01-24 175208

`#` 찜 추가 매개변수 변경
`-` memberId 를 `UserPrincipal` 에서 받아옴
`#` 하드코딩된 memberId 수정
`#` 찜 추가 요청 값 조정
@laigasus laigasus added the bug Something isn't working label Jan 24, 2024
@laigasus laigasus self-assigned this Jan 24, 2024
@laigasus laigasus linked an issue Jan 24, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jan 24, 2024

Test Results

48 tests  ±0   48 ✅ ±0   2s ⏱️ ±0s
16 suites ±0    0 💤 ±0 
16 files   ±0    0 ❌ ±0 

Results for commit 79ba2f9. ± Comparison against base commit 291da6f.

♻️ This comment has been updated with latest results.

Copy link
Member

@Dr-KoKo Dr-KoKo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

현재 로그인되어있지 않은 경우 userPrincipal의 id 값이 null로 처리되기 때문에 0으로 변경하신걸까요?

Copy link
Contributor

@happymink happymink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

Copy link
Member

@NoJaeHyuk NoJaeHyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

@laigasus
Copy link
Member Author

@Dr-KoKo 네 그렇습니다
PreAuthorize("isAuthenticated()") 를 이용해왔는데, 따로 다른 분들이 구현하신 것이 없어 보여서.
당장 예외처리는 하지 않고, 수행여부만 데이터로 전달하고 있습니다!

@Dr-KoKo
Copy link
Member

Dr-KoKo commented Jan 24, 2024

그럼 이렇게 처리하기보다는 로그인하지않은 경우 전역적으로 id가 0으로 내려오게 처리해둘게요. SecurityConfig에서 처리가능합니다

@laigasus
Copy link
Member Author

@Dr-KoKo 정해주신 규칙에 따르겠습니다.

@laigasus laigasus merged commit 487c8e3 into develop Jan 24, 2024
3 checks passed
@laigasus laigasus deleted the feature/#175-fix-wish branch January 26, 2024 09:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[REQ] Wish 엔드포인트 Request 수정 요청
5 participants