This repository has been archived by the owner on Mar 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
[Refactor/Fix] Wish 엔드포인트 조정 및 부분 오류 수정 #176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`#` 찜 추가 매개변수 변경
`-` memberId 를 `UserPrincipal` 에서 받아옴
`#` 하드코딩된 memberId 수정 `#` 찜 추가 요청 값 조정
Dr-KoKo
reviewed
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
현재 로그인되어있지 않은 경우 userPrincipal의 id 값이 null로 처리되기 때문에 0으로 변경하신걸까요?
happymink
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!
NoJaeHyuk
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다.
@Dr-KoKo 네 그렇습니다 |
그럼 이렇게 처리하기보다는 로그인하지않은 경우 전역적으로 id가 0으로 내려오게 처리해둘게요. SecurityConfig에서 처리가능합니다 |
@Dr-KoKo 정해주신 규칙에 따르겠습니다. |
Nine-JH
approved these changes
Jan 24, 2024
Dr-KoKo
approved these changes
Jan 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경사항
#
찜 추가 엔드포인트의 body 값이 변경되었습니다.(body로 받는 memberId 를 UserPrincipal 로 대체)#
찜 삭제시 고정되어있던 memberId 값 수정Issue Link - #175
체크리스트
리뷰 요청 전에 확인해야 할 사항들을 나열해주세요.
참고