refactor: drop the slowest run

Strumenta · Jan 31, 2024 · 5961d4b · 5961d4b
1 parent 335c592
commit 5961d4b
Showing 1 changed file with 14 additions and 4 deletions.
diff --git a/...arks/src/commonTest/kotlin/org/antlr/v4/kotlinruntime/benchmarks/ManualMySQLBenchmarks.kt b/...arks/src/commonTest/kotlin/org/antlr/v4/kotlinruntime/benchmarks/ManualMySQLBenchmarks.kt
@@ -54,6 +54,10 @@ class ManualMySQLBenchmarks {
   }
 
   private fun averageTimeMs(title: String, times: Int, action: () -> Duration): Double {
+    require(times > 3) {
+      "At least 4 iterations are required"
+    }
+
     val durations = ArrayList<Duration>(times)
     println("\nBenchmark: $title")
 
@@ -68,12 +72,18 @@ class ManualMySQLBenchmarks {
   }
 
   private fun averageMs(durations: List<Duration>): Double {
-    if (durations.isEmpty()) {
-      return 0.0
+    require(durations.size > 3) {
+      "At least 4 durations are required"
     }
 
-    val sum = durations.fold(Duration.ZERO) { acc, duration -> acc + duration }
-    val duration = sum / durations.size
+    // Sort and drop the slowest run
+    val durationsMinusSlowest = durations.asSequence()
+      .sortedDescending()
+      .drop(1)
+      .toList()
+
+    val sum = durationsMinusSlowest.fold(Duration.ZERO) { acc, duration -> acc + duration }
+    val duration = sum / durationsMinusSlowest.size
     return milliseconds(duration)
   }