Add case insensitive symbol lookup in Scope and inherit @internal_properties #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds feature described in issue Strumenta#9
they are no longer overwritten in subclasses, rather they add onto the already present ones (inherited from the relative superclass)
thatsOven
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds feature described in issue #9.
The feature is implemented in such a way that the necessary mappings for case insensitive lookups are generated on the fly and cached when such a lookup is requested, and then dynamically get updated with each symbol addition. This way, no time or memory is wasted in case a case insensitive lookup is never performed.
Also addresses issue #25.
Internal properties are now added onto existing ones through the @internal_properties decorator. This means that subclasses can inherit
__internal_properties__from relative superclasses without overwriting them.